Kafka
  1. Kafka
  2. KAFKA-195

change ProducerShell to use high level producer

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.7
    • Fix Version/s: 0.7
    • Component/s: None
    • Labels:
      None

      Description

      We need to change ProducerShell to use high level producer and provide a default producer property file

      1. KAFKA-195-v2.patch
        6 kB
        Jun Rao
      2. KAFKA-195.patch
        4 kB
        Jun Rao

        Activity

        Hide
        Jun Rao added a comment -

        With this patch, we also need to change quick start in our web site to the following:

        bin/kafka-producer-shell.sh --props config/producer.properties --topic test

        Show
        Jun Rao added a comment - With this patch, we also need to change quick start in our web site to the following: bin/kafka-producer-shell.sh --props config/producer.properties --topic test
        Hide
        Jun Rao added a comment -

        Attache v2 of the patch. Include more properties in producer property file.

        Show
        Jun Rao added a comment - Attache v2 of the patch. Include more properties in producer property file.
        Hide
        Neha Narkhede added a comment -

        +1. Lets include this in the next RC

        Show
        Neha Narkhede added a comment - +1. Lets include this in the next RC
        Hide
        Jun Rao added a comment -

        Committed to trunk. Need to merge into 0.7 branch if we plan to include this in the latest 0.7 RC.

        Show
        Jun Rao added a comment - Committed to trunk. Need to merge into 0.7 branch if we plan to include this in the latest 0.7 RC.
        Hide
        Neha Narkhede added a comment -

        Please also commit the diff to the 0.7 branch.

        Show
        Neha Narkhede added a comment - Please also commit the diff to the 0.7 branch.
        Hide
        Jay Kreps added a comment -

        Why are we doing this? KAFKA-180 is to get rid of this code entirely--it is totally replaced by kafka-console-producer.sh, right? It is weird that we have two of these, and I am not sure why we are coding on the old one.

        Show
        Jay Kreps added a comment - Why are we doing this? KAFKA-180 is to get rid of this code entirely--it is totally replaced by kafka-console-producer.sh, right? It is weird that we have two of these, and I am not sure why we are coding on the old one.
        Hide
        Jun Rao added a comment -

        The main reason is that we don't have an example producer property file and an actual use case. With this patch, there is such a property file that a user can refer to.

        Show
        Jun Rao added a comment - The main reason is that we don't have an example producer property file and an actual use case. With this patch, there is such a property file that a user can refer to.

          People

          • Assignee:
            Jun Rao
            Reporter:
            Jun Rao
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development