Uploaded image for project: 'Kafka'
  1. Kafka
  2. KAFKA-1926

Replace kafka.utils.Utils with o.a.k.common.utils.Utils

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 0.8.2.0
    • 0.9.0.0
    • None

    Description

      There is currently a lot of duplication between the Utils class in common and the one in core.

      Our plan has been to deprecate duplicate code in the server and replace it with the new common code.

      As such we should evaluate each method in the scala Utils and do one of the following:
      1. Migrate it to o.a.k.common.utils.Utils if it is a sensible general purpose utility in active use that is not Kafka-specific. If we migrate it we should really think about the API and make sure there is some test coverage. A few things in there are kind of funky and we shouldn't just blindly copy them over.
      2. Create a new class ServerUtils or ScalaUtils in kafka.utils that will hold any utilities that really need to make use of Scala features to be convenient.
      3. Delete it if it is not used, or has a bad api.

      Attachments

        1. KAFKA-1926_2015-04-01_22:16:46.patch
          220 kB
          Tong Li
        2. KAFKA-1926_2015-04-05_23:45:13.patch
          223 kB
          Tong Li
        3. KAFKA-1926.patch
          223 kB
          Tong Li
        4. KAFKA-1926.patch
          187 kB
          Tong Li
        5. KAFKA-1926.patch
          49 kB
          Tong Li
        6. KAFKA-1926.patch
          47 kB
          Tong Li

        Activity

          People

            tongli Tong Li
            jkreps Jay Kreps
            Jun Rao Jun Rao
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: