Kafka
  1. Kafka
  2. KAFKA-184

Log retention size and file size should be a long

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.7
    • Fix Version/s: 0.8.1
    • Component/s: None
    • Labels:
      None

      Description

      Realized this in a local set up: the log.retention.size config option should be a long, or we're limited to 2GB. Also, the name can be improved to log.retention.size.bytes or Mbytes as appropriate. Same comments for log.file.size. If we rename the configs, it would be better to resolve KAFKA-181 first.

      1. KAFKA-184-0.8.patch
        2 kB
        Jonathan Creasy

        Activity

        Joel Koshy created issue -
        Hide
        Jonathan Creasy added a comment -

        The first part of this appears to be changed in the 0.8 branch.

        /* the maximum size of the log before deleting it */
        val logRetentionSize = Utils.getLong(props, "log.retention.size", -1)

        Show
        Jonathan Creasy added a comment - The first part of this appears to be changed in the 0.8 branch. /* the maximum size of the log before deleting it */ val logRetentionSize = Utils.getLong(props, "log.retention.size", -1)
        Jonathan Creasy made changes -
        Field Original Value New Value
        Attachment KAFKA-184-0.8.patch [ 12536926 ]
        Jonathan Creasy made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Affects Version/s 0.7 [ 12317243 ]
        Hide
        Jonathan Creasy added a comment -

        Added patch to change log.retention.size to log.retention.size.bytes, and updated included server.properties

        Show
        Jonathan Creasy added a comment - Added patch to change log.retention.size to log.retention.size.bytes, and updated included server.properties
        Hide
        Jay Kreps added a comment -

        Thanks! I am going to hold off on this. As you mention, changing the name of the properties is kind of undesirable as people would likely not notice and silently set the wrong thing. Fixing KAFKA-181 would make this less painful. In particular it would be nice to have aliases so we can fix config names but still conveniently allow the old name. Will add a comment to that ticket.

        Show
        Jay Kreps added a comment - Thanks! I am going to hold off on this. As you mention, changing the name of the properties is kind of undesirable as people would likely not notice and silently set the wrong thing. Fixing KAFKA-181 would make this less painful. In particular it would be nice to have aliases so we can fix config names but still conveniently allow the old name. Will add a comment to that ticket.
        Joe Stein made changes -
        Fix Version/s 0.8.1 [ 12322960 ]
        Fix Version/s 0.8 [ 12317244 ]
        Hide
        Sriram Subramanian added a comment -

        We have already fixed all the config naming and types in 0.8. We can resolve this.

        Show
        Sriram Subramanian added a comment - We have already fixed all the config naming and types in 0.8. We can resolve this.
        Sriram Subramanian made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Joel Koshy
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development