Uploaded image for project: 'Kafka'
  1. Kafka
  2. KAFKA-169

Layering violations in Kafka code

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Won't Fix
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: core
    • Labels:
      None

      Description

      I am noticing lot of layering violations creeping into the code.

      For example the log implementation depends on zookeeper code now, the network server depends on the kafka api, etc. This stuff is messy and makes it hard to test or reason about the pieces in isolation.

      I have run a quick analysis on the imports to look at problems and there are a few. Let's try to keep this graph in good shape and think about the layering in the code.

        Attachments

        1. kafka_deps.svg
          19 kB
          Jay Kreps
        2. draw_deps.py
          0.7 kB
          Jay Kreps

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              jkreps Jay Kreps
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: