[KAFKA-15533] Ensure HeartbeatRequestManager only send out some fields once

• Type: Sub-task
• Status: Resolved
• Priority: Minor
• Resolution: Resolved
• Fix Version/s: 3.7.0
• Component/s: clients, consumer
• Labels: kip-848 kip-848-client-support
• Assignee: Philip Nee
• Reporter: Philip Nee
• Created: 03/Oct/23 17:54
• Updated: 19/Dec/23 03:15
• Resolved: 04/Dec/23 18:38

Description

We want to ensure ConsumerGroupHeartbeatRequest is as lightweight as possible, so a lot of fields in it don't need to be resend. An example would be the rebalanceTimeoutMs, currently we have the following code:

 

 

ConsumerGroupHeartbeatRequestData data = new ConsumerGroupHeartbeatRequestData()
    .setGroupId(membershipManager.groupId())
    .setMemberEpoch(membershipManager.memberEpoch())
    .setMemberId(membershipManager.memberId())
    .setRebalanceTimeoutMs(rebalanceTimeoutMs); 

 

 

We should encapsulate these once-used fields into a class such as HeartbeatMetdataBuilder, and it should maintain a state of whether a certain field needs to be sent or not.

 

Note that, currently only 3 fields are mandatory in the request:

• groupId
• memberEpoch
• memberId

Note that on retriable errors and network errors (ex. timeout) a full request should be sent to the broker.

Issue Links

• is part of: KAFKA-14246 Update threading model for Consumer