Kafka
  1. Kafka
  2. KAFKA-1517

Messages is a required argument to Producer Performance Test

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 0.8.1.1
    • Fix Version/s: 0.8.3
    • Component/s: None
    • Labels:

      Description

      When running the producer performance test without providing a messages argument, you get an error:

      $bin/kafka-producer-perf-test.sh --topics mirrormirror --broker-list kafka-dc21:9092
      Missing required argument "[messages]"
      
      Option                                  Description
      ------                                  -----------
      ......
      --messages <Long: count>                The number of messages to send or
                                                consume (default:
                                                9223372036854775807)
      

      However the shell command documentation doesn't say that this is required and implies that 2^63-1 (Long.MaxValue) messages will be sent. It should probably look like the ConsoleProducer and prefix the documentation with REQUIRED. Or should we make this a non-required argument and set the default value to something sane like 100,000 messages.

      Which option is preferable for this?

        Activity

        Hide
        Jun Rao added a comment -

        Sorry for the late review. +1 and committed to trunk.

        Show
        Jun Rao added a comment - Sorry for the late review. +1 and committed to trunk.
        Hide
        Daniel Compton added a comment -

        I've attached a patch for this. Let me know if the patch isn't correct, I wasn't sure I was doing it correctly.

        Show
        Daniel Compton added a comment - I've attached a patch for this. Let me know if the patch isn't correct, I wasn't sure I was doing it correctly.
        Hide
        Daniel Compton added a comment -

        Great, I'll prepare a patch, documenting it as mandatory and removing the default value.

        Show
        Daniel Compton added a comment - Great, I'll prepare a patch, documenting it as mandatory and removing the default value.
        Hide
        Jun Rao added a comment -

        Yes, I think it would be better if we document it as required and get rid of the default.

        Show
        Jun Rao added a comment - Yes, I think it would be better if we document it as required and get rid of the default.

          People

          • Assignee:
            Daniel Compton
            Reporter:
            Daniel Compton
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development