[KAFKA-1508] Scripts Break When Path Has Spaces

• Type: Bug
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 0.8.1.1
• Component/s: tools
• Labels: windows
• Environment: Any *nix flavor where the full path name to the Kafka deployment contains spaces
• Assignee: Rekha Joshi
• Reporter: Tim Olson
• Created: 24/Jun/14 21:29
• Updated: 24/Feb/18 06:31

Description

All the shell scripts in bin use the idom
$(dirname $0)
but this produces the error
usage: dirname path
if the path contains spaces. The correct way to get the dirname is to use:
"$(dirname "$0")"
and subsequently wrap the result in quotes when it is used. For example, the file bin/kafka-run-class.sh should look like this starting line 23:

# BUGFIX: quotes added
base_dir="$(dirname "$0")/.."

# create logs directory
# BUGFIX: quotes added
LOG_DIR="$base_dir/logs"
if [ ! -d "$LOG_DIR" ]; then
    # BUGFIX: quotes added around $LOG_DIR
    mkdir "$LOG_DIR"
fi
# ...
# BUGFIX: quotes added
for file in "$base_dir/core/build/dependant-libs-${SCALA_VERSION}/*.jar";
do
  CLASSPATH=$CLASSPATH:"$file"
done

Issue Links

• is duplicated by: KAFKA-2780 kafka-server-start.sh globbing issue
• is related to: KAFKA-3692 Wildcards in External CLASSPATH may cause it not be included in the CLASSPATH