Uploaded image for project: 'Kafka'
  1. Kafka
  2. KAFKA-14728

Remove 'spotlessScalaCheck' task (out of Jenkinsfile)

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • None
    • build
    • None

    Description

      Note: this ticket blocks Gradle major version upgrade (7 -->> 8): KAFKA-14680

      Rationale:

      • build works fine in trunk with Gradle 7.6 and spotless gradle plugin 6.13.0 for all currently used JDK versions (that is: JDK 8 / JDK 11 / JDK 17)
      • however, recent spotless gradle plugin versions (6.14.+) support only JDK 11+ versions: https://github.com/diffplug/spotless/blob/main/plugin-gradle/CHANGES.md#6140---2023-01-26
      • at the moment Kafka build powered by Gradle 8.0 breaks when combined with all relevant spotless gradle plugin versions (from 6.13.0 to 6.15.0); github issue is created here
      • given a fact that Kafka still needs to support JDK 8 builds (until Kafka version 4.0) it is reasonable to simply remove spotless checks out of Jenkinsfile (and re-introduce them when the time comes).

      For even more details see GitHub discussion here: https://github.com/apache/kafka/pull/13205#issuecomment-1431575644

      Note: spotless plugin configuration in build.gradle is out of this ticket scope.

      Attachments

        Issue Links

          Activity

            People

              dejan2609 Dejan Stojadinović
              dejan2609 Dejan Stojadinović
              Ismael Juma Ismael Juma
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: