[KAFKA-14618] Off by one error in generated snapshot IDs causes misaligned fetching

• Type: Bug
• Status: Resolved
• Priority: Blocker
• Resolution: Fixed
• Fix Version/s: 3.4.0
• Assignee: José Armando García Sancio
• Reporter: Jason Gustafson
• Created: 12/Jan/23 22:51
• Updated: 13/Jan/23 23:19
• Resolved: 13/Jan/23 21:25

Description

We implemented new snapshot generation logic here: https://github.com/apache/kafka/pull/12983. A few days prior to this patch getting merged, we had changed the `RaftClient` API to pass the exclusive offset when generating snapshots instead of the inclusive offset: https://github.com/apache/kafka/pull/12981. Unfortunately, the new snapshot generation logic was not updated accordingly. The consequence of this is that the state on replicas can get out of sync. In the best case, the followers fail replication because the offset after loading a snapshot is no longer aligned on a batch boundary.

Issue Links

• links to: GitHub Pull Request #13108