[KAFKA-14461] StoreQueryIntegrationTest#shouldQuerySpecificActivePartitionStores logic to check for active partitions seems brittle.

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Component/s: streams, unit tests
• Assignee: Sagar Rao
• Reporter: Sagar Rao
• Created: 11/Dec/22 16:21
• Updated: 21/Dec/22 12:34
• Resolved: 21/Dec/22 12:34

Description

StoreQueryIntegrationTest#shouldQuerySpecificActivePartitionStores 

has a logic to figure out active partitions:

 

 

final boolean kafkaStreams1IsActive = (keyQueryMetadata.activeHost().port() % 2) == 1;

 

 

This is very brittle as when a new test gets added, this check would need to be changed to `==0`. It's a hassle to change it everytime with a new test added. Should look to improve this.

Also, this test relies on junit4 annotations which can be migrated to Junit 5 so that we can use @BeforeAll to set up and @AfterAll to shutdown the cluster instead of the current way where it's being done before/after every test.

 

Issue Links

• is a clone of: KAFKA-14454 KTableKTableForeignKeyInnerJoinCustomPartitionerIntegrationTest#shouldThrowIllegalArgumentExceptionWhenCustomPartionerReturnsMultiplePartitions passes when run individually but not when is run as part of the IT
• links to: GitHub Pull Request #13014