Kafka
  1. Kafka
  2. KAFKA-143

Check and make sure that all source code distributed by the project is covered by one or more approved licenses

    Details

    • Type: Task Task
    • Status: Resolved
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.7
    • Component/s: None
    • Labels:
      None

      Description

      Check and make sure that all source code distributed by the project is covered by one or more of the following approved licenses: Apache, BSD, Artistic, MIT/X, MIT/W3C, MPL 1.1, or something with essentially the same terms

      1. rat-excludes
        0.3 kB
        Neha Narkhede
      2. rat.out
        45 kB
        Neha Narkhede
      3. KAFKA-143-rat.patch
        19 kB
        Neha Narkhede
      4. kafka-0.7.0-RC2.rat
        139 kB
        Neha Narkhede
      5. KAFKA-143.patch
        68 kB
        Neha Narkhede

        Activity

        Hide
        Alan Cabrera added a comment -

        We also need to run Rat to make sure that all the files have the appropriate headers. You'd be surprised at how many superfluous files need to be "stamped".

        Show
        Alan Cabrera added a comment - We also need to run Rat to make sure that all the files have the appropriate headers. You'd be surprised at how many superfluous files need to be "stamped".
        Hide
        Neha Narkhede added a comment -

        Fixed some contrib and clients to have the Apache License header, as well as the LICENSE file. With this, I think we have made sure all code distributed by Kafka is Apache 2.0 compatible

        Show
        Neha Narkhede added a comment - Fixed some contrib and clients to have the Apache License header, as well as the LICENSE file. With this, I think we have made sure all code distributed by Kafka is Apache 2.0 compatible
        Hide
        Jun Rao added a comment -

        +1 on the patch.

        Show
        Jun Rao added a comment - +1 on the patch.
        Hide
        Chris Burroughs added a comment -
        • LICENSE files need to have the "Copyright [yyyy] [name of copyright owner]" line filled in.
        • We can't remove the FSF copyright notice that says we can redistribute "as long as this notice is preserved." I'm not sure how m4/autoconf type files are supposed to be handled.
        Show
        Chris Burroughs added a comment - LICENSE files need to have the "Copyright [yyyy] [name of copyright owner] " line filled in. We can't remove the FSF copyright notice that says we can redistribute "as long as this notice is preserved." I'm not sure how m4/autoconf type files are supposed to be handled.
        Hide
        Neha Narkhede added a comment -

        I'll fix the LICENSE files.
        For the FSF copyright, if that is really required, why don't any other files have it ? like other clients, contrib etc ?

        Show
        Neha Narkhede added a comment - I'll fix the LICENSE files. For the FSF copyright, if that is really required, why don't any other files have it ? like other clients, contrib etc ?
        Hide
        Neha Narkhede added a comment -

        Fixed LICENSE files in contrib and clients.

        For the "Copyright [yyyy] [name of copyright owner]" part, it is the same in almost all incubator projects, and also in top level Apache projects like Zookeeper.

        So leaving it as is.

        Show
        Neha Narkhede added a comment - Fixed LICENSE files in contrib and clients. For the "Copyright [yyyy] [name of copyright owner] " part, it is the same in almost all incubator projects, and also in top level Apache projects like Zookeeper. So leaving it as is.
        Hide
        Alan Cabrera added a comment -

        Still have lots of Rat failures.

        Show
        Alan Cabrera added a comment - Still have lots of Rat failures.
        Hide
        Neha Narkhede added a comment -

        Uploading the rat output. Only

        1. README files and
        2. some make files and
        3. some package.html files don't have the header.
        4. System test .out files

        I wonder if the above files need the header ? Please advise!

        Show
        Neha Narkhede added a comment - Uploading the rat output. Only 1. README files and 2. some make files and 3. some package.html files don't have the header. 4. System test .out files I wonder if the above files need the header ? Please advise!
        Hide
        Neha Narkhede added a comment -

        Attaching a patch that corrects the remaining files that rat complains about. Now rat output passes with the attached .rat-excludes file. This .rat-excludes file is pending review on KAFKA-151.

        Show
        Neha Narkhede added a comment - Attaching a patch that corrects the remaining files that rat complains about. Now rat output passes with the attached .rat-excludes file. This .rat-excludes file is pending review on KAFKA-151 .
        Hide
        Jun Rao added a comment -

        +1 with the new patch.

        Show
        Jun Rao added a comment - +1 with the new patch.
        Hide
        Neha Narkhede added a comment -

        Rat test passes with 0 failures

        Show
        Neha Narkhede added a comment - Rat test passes with 0 failures

          People

          • Assignee:
            Neha Narkhede
            Reporter:
            Alan Cabrera
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development