Uploaded image for project: 'Kafka'
  1. Kafka
  2. KAFKA-1410

MetadataCache cleanup

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.8.2.0
    • Fix Version/s: 0.8.2.0
    • Component/s: core
    • Labels:
      None

      Description

      There are a few remaining cleanup items from KAFKA-1356 for trunk.

      1. There is no need to call ensureTopicExists(). A consistent check would require holding the read lock of metadata cache on every fetch/producer request, which means a metadata update could block all fetch/producer requests. Also, this call is just an optimization. When leaderAndIsrRequest is propagated after a topic deletion, fetch/producer requests will be rejected by the ReplicaManager.

      2. The update of the controller epoc when handling metadata request needs to be done inside the replicaStateChangeLock.

        Attachments

        1. KAFKA-1410_2014-04-22_13:51:26.patch
          25 kB
          Jun Rao
        2. KAFKA-1410_2014-04-22_09:37:36.patch
          29 kB
          Jun Rao
        3. KAFKA-1410.patch
          21 kB
          Jun Rao

          Activity

            People

            • Assignee:
              junrao Jun Rao
              Reporter:
              junrao Jun Rao
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: