[KAFKA-14104] Perform CRC validation on KRaft Batch Records and Snapshots

• Type: Bug
• Status: Resolved
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 3.2.0
• Fix Version/s: 3.3.0
• Assignee: Niket Goel
• Reporter: Niket Goel
• Created: 25/Jul/22 20:40
• Updated: 08/Aug/22 22:42
• Resolved: 08/Aug/22 22:42

Description

Today we stamp the BatchRecord header with a CRC [1] and verify that CRC before the log is written to disk [2]. The CRC checks should also be verified when the records are read back from disk. The same procedure should be followed for KRaft snapshots as well.

[1] https://github.com/apache/kafka/blob/6b76c01cf895db0651e2cdcc07c2c392f00a8ceb/clients/src/main/java/org/apache/kafka/common/record/DefaultRecordBatch.java#L501=

[2] https://github.com/apache/kafka/blob/679e9e0cee67e7d3d2ece204a421ea7da31d73e9/core/src/main/scala/kafka/log/UnifiedLog.scala#L1143

Issue Links

• is duplicated by: KAFKA-13806 Check CRC when reading snapshots
• links to: GitHub Pull Request #12457