Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.8.2.0
    • Fix Version/s: 0.8.2.0
    • Component/s: producer
    • Labels:
      None

      Description

      New producer configs have been added somewhat haphazardly. Before we consider the producer final, let's do the following:
      1. Go back and think about all the config names and make sure they are really what we want.
      2. Add doc strings for all the configs
      3. Make the config keys non-public.
      4. Add a feature to differentiate important from non-important configs.
      5. Add code to generate the website documentation off the internal config docs.

      1. KAFKA-1337.patch
        8 kB
        Jay Kreps
      2. KAFKA-1337.patch
        0.8 kB
        Guozhang Wang
      3. KAFKA-1337.patch
        16 kB
        Guozhang Wang
      4. KAFKA-1337.patch
        62 kB
        Jay Kreps

        Activity

        Hide
        jkreps Jay Kreps added a comment -

        Created reviewboard https://reviews.apache.org/r/19831/
        against branch trunk

        Show
        jkreps Jay Kreps added a comment - Created reviewboard https://reviews.apache.org/r/19831/ against branch trunk
        Hide
        jkreps Jay Kreps added a comment -

        This patch goes through and attempts to rename the configs in a consistent way. I also added the code to automatically generate config documentation off the code as well as adding documentation for all the current configs. In addition to the patch please review the configs and their docs here:
        http://kafka.apache.org/081/documentation.html#newproducerconfigs

        Show
        jkreps Jay Kreps added a comment - This patch goes through and attempts to rename the configs in a consistent way. I also added the code to automatically generate config documentation off the code as well as adding documentation for all the current configs. In addition to the patch please review the configs and their docs here: http://kafka.apache.org/081/documentation.html#newproducerconfigs
        Hide
        nehanarkhede Neha Narkhede added a comment -

        This looks really good. I have posted minor comments that you can address on checkin. Otherwise, I'm a +1 on this.

        Show
        nehanarkhede Neha Narkhede added a comment - This looks really good. I have posted minor comments that you can address on checkin. Otherwise, I'm a +1 on this.
        Hide
        jkreps Jay Kreps added a comment -

        Cool, Neha I addressed your comments except for one which we can discuss further.

        Jun and Guozhang I addressed your comments. Happy to take any follow-up items people see.

        Show
        jkreps Jay Kreps added a comment - Cool, Neha I addressed your comments except for one which we can discuss further. Jun and Guozhang I addressed your comments. Happy to take any follow-up items people see.
        Hide
        guozhang Guozhang Wang added a comment -

        Created reviewboard https://reviews.apache.org/r/20111/
        against branch origin/trunk

        Show
        guozhang Guozhang Wang added a comment - Created reviewboard https://reviews.apache.org/r/20111/ against branch origin/trunk
        Hide
        nehanarkhede Neha Narkhede added a comment -

        +1. Checked in the follow up patch to trunk

        Show
        nehanarkhede Neha Narkhede added a comment - +1. Checked in the follow up patch to trunk
        Hide
        junrao Jun Rao added a comment -

        Some follow up comments:
        TIMEOUT_CONFIG => TIMEOUT_MS_CONFIG
        METADATA_FETCH_TIMEOUT_CONFIG => METADATA_FETCH_TIMEOUT_MS_CONFIG
        METADATA_MAX_AGE_CONFIG => METADATA_MAX_AGE_MS_CONFIG

        Show
        junrao Jun Rao added a comment - Some follow up comments: TIMEOUT_CONFIG => TIMEOUT_MS_CONFIG METADATA_FETCH_TIMEOUT_CONFIG => METADATA_FETCH_TIMEOUT_MS_CONFIG METADATA_MAX_AGE_CONFIG => METADATA_MAX_AGE_MS_CONFIG
        Hide
        guozhang Guozhang Wang added a comment -

        Created reviewboard https://reviews.apache.org/r/20224/
        against branch origin/trunk

        Show
        guozhang Guozhang Wang added a comment - Created reviewboard https://reviews.apache.org/r/20224/ against branch origin/trunk
        Hide
        junrao Jun Rao added a comment -

        Thanks for the delta patch. Committed to trunk.

        Show
        junrao Jun Rao added a comment - Thanks for the delta patch. Committed to trunk.
        Hide
        jkreps Jay Kreps added a comment -

        Looks like I missed a few hardcoded configs (or else they came in parallel to this patch).

        Show
        jkreps Jay Kreps added a comment - Looks like I missed a few hardcoded configs (or else they came in parallel to this patch).
        Hide
        jkreps Jay Kreps added a comment -

        Created reviewboard https://reviews.apache.org/r/20440/
        against branch trunk

        Show
        jkreps Jay Kreps added a comment - Created reviewboard https://reviews.apache.org/r/20440/ against branch trunk
        Hide
        jkreps Jay Kreps added a comment -

        This should be a pretty trivial patch that fixes a bunch of broken command line tools.

        Show
        jkreps Jay Kreps added a comment - This should be a pretty trivial patch that fixes a bunch of broken command line tools.
        Hide
        junrao Jun Rao added a comment -

        The followup patch has been committed to 0.8.2. Resolving the jira.

        Show
        junrao Jun Rao added a comment - The followup patch has been committed to 0.8.2. Resolving the jira.

          People

          • Assignee:
            jkreps Jay Kreps
            Reporter:
            jkreps Jay Kreps
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development