[KAFKA-13078] Closing FileRawSnapshotWriter too early

• Type: Bug
• Status: Resolved
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 3.0.0
• Fix Version/s: 3.0.0
• Component/s: kraft
• Labels: kip-500
• Assignee: Jose Armando Garcia Sancio
• Reporter: Jose Armando Garcia Sancio
• Created: 13/Jul/21 17:58
• Updated: 14/Jul/21 22:40
• Resolved: 14/Jul/21 22:40

Description

We are getting the following error

  [2021-07-13 17:23:42,174] ERROR [kafka-raft-io-thread]: Error due to (kafka.raft.KafkaRaftManager$RaftIoThread)
  java.io.UncheckedIOException: Error calculating snapshot size. temp path = /mnt/kafka/kafka-metadata-logs/@metadata-0/00000000000000000062-0000000002-3249768281228588378.checkpoint.part, snapshotId = OffsetAndEpoch(offset=62, epoch=2).
      at org.apache.kafka.snapshot.FileRawSnapshotWriter.sizeInBytes(FileRawSnapshotWriter.java:63)
      at org.apache.kafka.raft.KafkaRaftClient.maybeSendFetchOrFetchSnapshot(KafkaRaftClient.java:2044)
      at org.apache.kafka.raft.KafkaRaftClient.pollFollowerAsObserver(KafkaRaftClient.java:2032)
      at org.apache.kafka.raft.KafkaRaftClient.pollFollower(KafkaRaftClient.java:1995)
      at org.apache.kafka.raft.KafkaRaftClient.pollCurrentState(KafkaRaftClient.java:2104)
      at org.apache.kafka.raft.KafkaRaftClient.poll(KafkaRaftClient.java:2217)
      at kafka.raft.KafkaRaftManager$RaftIoThread.doWork(RaftManager.scala:52)
      at kafka.utils.ShutdownableThread.run(ShutdownableThread.scala:96)
  Caused by: java.nio.channels.ClosedChannelException
      at sun.nio.ch.FileChannelImpl.ensureOpen(FileChannelImpl.java:110)
      at sun.nio.ch.FileChannelImpl.size(FileChannelImpl.java:300)
      at org.apache.kafka.snapshot.FileRawSnapshotWriter.sizeInBytes(FileRawSnapshotWriter.java:60)
      ... 7 more
 

This is because the FollowerState is closing the snapshot write passed through the argument instead of the one being replaced.

Issue Links

• links to: GitHub Pull Request #11040