[KAFKA-1307] potential socket leak in new producer and clean up

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.8.2.0
• Fix Version/s: 0.8.2.0
• Component/s: core
• Assignee: Jun Rao
• Reporter: Jun Rao
• Created: 17/Mar/14 17:06
• Updated: 18/Mar/14 17:56
• Resolved: 18/Mar/14 17:56

Description

Address the delta review comments from kafka-1227.

20. Selector and Sender: need to close socket channel on IOException in addition to UnresolvedHostnameException.
21. AbstractConfig:
21.1 To be consistent, we probably should change the return value of the following api from Long to long.
public Long getLong(String key)
21.1 Could we also add getDouble(String key)?
22. Metadata.fetch(): The wait time is incorrect when there is an InterruptedException.
23. Add comments on BufferPool.allocate() and Struct.instanceOf() for clarification.
24. Various other minor fixes for mis-spelling.