[KAFKA-12981] Ensure LogSegment.maxTimestampSoFar and LogSegment.offsetOfMaxTimestampSoFar are read/updated in sync

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 3.0.0
• Assignee: Tom Scott
• Reporter: Tom Scott
• Reviewer: David Jacot
• Created: 22/Jun/21 19:41
• Updated: 06/Jul/21 17:28
• Resolved: 06/Jul/21 17:28

Description

KIP-734 extends listOffsetRequest to fetch offsets by max timestamp as well as by start and end offset. This relies on LogSegment.maxTimestampSoFar and LogSegment.offsetOfMaxTimestampSoFar  but there is currently no synchronisation between the 2 meaning that one could be updated whilst the other is being read.

This ticket ensure that LogSegment.maxTimestampSoFar and LogSegment.offsetOfMaxTimestampSoFar are locked on read to ensure synchronisation.

Issue Links

• links to: GitHub Pull Request #10959
• links to: GitHub Pull Request #10960