Kafka
  1. Kafka
  2. KAFKA-1291

Make wrapper shell scripts for important tools

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.8.1
    • Fix Version/s: 0.8.2.0
    • Component/s: None
    • Labels:

      Description

      It is nice to have a proper command for the important tools just to help with discoverability. I noticed that mirror maker doesn't have such a wrapper. Neither does consumer offset checker. It would be good to do an audit and think of any tools that should have a wrapper that don't.

      1. KAFKA-1291.patch
        47 kB
        Jay Kreps
      2. KAFKA-1291.patch
        20 kB
        Sebastian Geller
      3. KAFKA-1291.patch
        20 kB
        Sebastian Geller

        Activity

        Hide
        Sebastian Geller added a comment -

        Created reviewboard against branch origin/trunk

        Show
        Sebastian Geller added a comment - Created reviewboard against branch origin/trunk
        Hide
        Sebastian Geller added a comment -

        Created reviewboard https://reviews.apache.org/r/22479/diff/
        against branch origin/trunk

        Show
        Sebastian Geller added a comment - Created reviewboard https://reviews.apache.org/r/22479/diff/ against branch origin/trunk
        Hide
        Jay Kreps added a comment -

        Created reviewboard https://reviews.apache.org/r/22744/
        against branch trunk

        Show
        Jay Kreps added a comment - Created reviewboard https://reviews.apache.org/r/22744/ against branch trunk
        Hide
        Jay Kreps added a comment -

        Hey Sebastian Geller this is great! I updated this patch a bit:
        1. I removed the shell script for a couple of tools that seemed kind of esoteric and seemed more likely to add confusion.
        2. I made all commands print a one-line explanation of what they do when run without arguments. Let me know if you think this description seems reasonable.
        3. I refactored a little bit of the cut-and-paste in our command line args definition.

        This should be an easy patch to review as most changes are trivial.

        Show
        Jay Kreps added a comment - Hey Sebastian Geller this is great! I updated this patch a bit: 1. I removed the shell script for a couple of tools that seemed kind of esoteric and seemed more likely to add confusion. 2. I made all commands print a one-line explanation of what they do when run without arguments. Let me know if you think this description seems reasonable. 3. I refactored a little bit of the cut-and-paste in our command line args definition. This should be an easy patch to review as most changes are trivial.
        Hide
        Jay Kreps added a comment -

        Specifically it would be good for someone to sanity check that the one-line description is correct and would convey the necessary information to someone trying to figure out what that command does.

        Show
        Jay Kreps added a comment - Specifically it would be good for someone to sanity check that the one-line description is correct and would convey the necessary information to someone trying to figure out what that command does.
        Hide
        Jay Kreps added a comment -

        Neha Narkhede I fixed the simple perf test issue you pointed out. I think I just confused myself that you had +1'd the patch by looking at the wrong issue and I just committed it. If you have any additional comments let me know and I will follow up.

        Show
        Jay Kreps added a comment - Neha Narkhede I fixed the simple perf test issue you pointed out. I think I just confused myself that you had +1'd the patch by looking at the wrong issue and I just committed it. If you have any additional comments let me know and I will follow up.

          People

          • Assignee:
            Unassigned
            Reporter:
            Jay Kreps
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development