Kafka
  1. Kafka
  2. KAFKA-1279

SocketServer.shutdown() doesn't close open connections

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      SocketServer.shutdown() stops the selector thread but doesn't actually close all the existing connections.

      In normal operations this doesn't matter much because right after shutting down the socket server the process exits which closes all the connections. However we found this issue during unit testing--essentially we are leaking all the connections so shutdown() doesn't actually cause any error at all on the client which is still able to write to the socket and just never receives a response.

        Activity

        Hide
        Jay Kreps added a comment -

        Created reviewboard https://reviews.apache.org/r/18441/
        against branch trunk

        Show
        Jay Kreps added a comment - Created reviewboard https://reviews.apache.org/r/18441/ against branch trunk

          People

          • Assignee:
            Jay Kreps
            Reporter:
            Jay Kreps
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development