[KAFKA-1277] Keep the summery/description when updating the RB with kafka-patch-review - ASF JIRA

Details

Type: Bug
Status: Resolved
Priority: Major
Resolution: Incomplete
Affects Version/s: None
Fix Version/s: None
Component/s: None
Labels:
None

Description

Today kafka-patch-review tool will always use a default title and description if they are not specified, even when updating an existing RB. Would better change to leave the current title/description as is.

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending

Attachments

KAFKA-1277_2014-10-04_16:39:56.patch

04/Oct/14 11:12

0.9 kB

Manikumar
KAFKA-1277_2014-10-04_16:51:20.patch

04/Oct/14 11:23

0.9 kB

Manikumar
KAFKA-1277_2014-10-04_16:57:30.patch

04/Oct/14 11:29

0.9 kB

Manikumar
KAFKA-1277_2014-10-04_17:00:37.patch

04/Oct/14 11:32

1 kB

Manikumar
KAFKA-1277_2014-10-04_17:01:43.patch

04/Oct/14 11:33

1 kB

Manikumar
KAFKA-1277_2014-10-04_17:03:08.patch

04/Oct/14 11:35

1 kB

Manikumar
KAFKA-1277_2014-10-04_17:09:02.patch

04/Oct/14 11:41

1 kB

Manikumar
KAFKA-1277_2014-10-05_11:04:33.patch

05/Oct/14 05:37

1 kB

Manikumar
KAFKA-1277_2014-10-05_11:09:08.patch

05/Oct/14 05:42

1 kB

Manikumar
KAFKA-1277_2014-10-05_11:10:50.patch

05/Oct/14 05:43

1 kB

Manikumar
KAFKA-1277_2014-10-05_11:18:17.patch

05/Oct/14 05:51

1 kB

Manikumar
KAFKA-1277.patch

05/Oct/14 05:47

1 kB

Manikumar
KAFKA-1277.patch

05/Oct/14 05:35

1 kB

Manikumar
KAFKA-1277.patch

04/Oct/14 11:09

0.9 kB

Manikumar

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Manikumar added a comment - 04/Oct/14 11:09

Created reviewboard https://reviews.apache.org/r/26340/diff/
against branch origin/trunk

Show

Manikumar added a comment - 04/Oct/14 11:09 Created reviewboard https://reviews.apache.org/r/26340/diff/ against branch origin/trunk

Hide

Permalink

Manikumar added a comment - 04/Oct/14 11:12

Updated reviewboard https://reviews.apache.org/r/26340/diff/
against branch origin/trunk

Show

Manikumar added a comment - 04/Oct/14 11:12 Updated reviewboard https://reviews.apache.org/r/26340/diff/ against branch origin/trunk

Hide

Permalink

Manikumar added a comment - 04/Oct/14 11:23

Updated reviewboard https://reviews.apache.org/r/26340/diff/
against branch origin/trunk

Show

Manikumar added a comment - 04/Oct/14 11:23 Updated reviewboard https://reviews.apache.org/r/26340/diff/ against branch origin/trunk

Hide

Permalink

Manikumar added a comment - 04/Oct/14 11:29

Updated reviewboard https://reviews.apache.org/r/26340/diff/
against branch origin/trunk

Show

Manikumar added a comment - 04/Oct/14 11:29 Updated reviewboard https://reviews.apache.org/r/26340/diff/ against branch origin/trunk

Hide

Permalink

Manikumar added a comment - 04/Oct/14 11:32

Updated reviewboard https://reviews.apache.org/r/26340/diff/
against branch origin/trunk

Show

Manikumar added a comment - 04/Oct/14 11:32 Updated reviewboard https://reviews.apache.org/r/26340/diff/ against branch origin/trunk

Hide

Permalink

Manikumar added a comment - 04/Oct/14 11:33

Updated reviewboard https://reviews.apache.org/r/26340/diff/
against branch origin/trunk

Show

Manikumar added a comment - 04/Oct/14 11:33 Updated reviewboard https://reviews.apache.org/r/26340/diff/ against branch origin/trunk

Hide

Permalink

Manikumar added a comment - 04/Oct/14 11:35

Updated reviewboard https://reviews.apache.org/r/26340/diff/
against branch origin/trunk

Show

Manikumar added a comment - 04/Oct/14 11:35 Updated reviewboard https://reviews.apache.org/r/26340/diff/ against branch origin/trunk

Hide

Permalink

Manikumar added a comment - 04/Oct/14 11:41

Updated reviewboard https://reviews.apache.org/r/26340/diff/
against branch origin/trunk

Show

Manikumar added a comment - 04/Oct/14 11:41 Updated reviewboard https://reviews.apache.org/r/26340/diff/ against branch origin/trunk

Hide

Permalink

Manikumar added a comment - 04/Oct/14 11:52

In this patch, I disabled the auto-setting of Summary and Description fields of RB request. Unless explicitly set, these fields will not get updated for existing RBs..

Show

Manikumar added a comment - 04/Oct/14 11:52 In this patch, I disabled the auto-setting of Summary and Description fields of RB request. Unless explicitly set, these fields will not get updated for existing RBs..

Hide

Permalink

Neha Narkhede added a comment - 04/Oct/14 23:18

Manikumar I tried testing the patch, but it failed with the following error

nnarkhed-mn1:kafka-git-idea nnarkhed$ python kafka-patch-review.py -j KAFKA-1277 -b trunk
Configuring reviewboard url to https://reviews.apache.org
Updating your remote branches to pull the latest changes
Usage: rbt post [options] [changenum]

Uploads diffs to create and update review requests.

rbt: error: --guess-fields option does not take a value
ERROR: reviewboard update failed. Exiting.

Show

Neha Narkhede added a comment - 04/Oct/14 23:18 Manikumar I tried testing the patch, but it failed with the following error nnarkhed-mn1:kafka-git-idea nnarkhed$ python kafka-patch-review.py -j KAFKA-1277 -b trunk Configuring reviewboard url to https://reviews.apache.org Updating your remote branches to pull the latest changes Usage: rbt post [options] [changenum] Uploads diffs to create and update review requests. rbt: error: --guess-fields option does not take a value ERROR: reviewboard update failed. Exiting.

Hide

Permalink

Manikumar added a comment - 05/Oct/14 05:35

Created reviewboard https://reviews.apache.org/r/26348/diff/
against branch origin/trunk

Show

Manikumar added a comment - 05/Oct/14 05:35 Created reviewboard https://reviews.apache.org/r/26348/diff/ against branch origin/trunk

Hide

Permalink

Manikumar added a comment - 05/Oct/14 05:37

Updated reviewboard https://reviews.apache.org/r/26348/diff/
against branch origin/trunk

Show

Manikumar added a comment - 05/Oct/14 05:37 Updated reviewboard https://reviews.apache.org/r/26348/diff/ against branch origin/trunk

Hide

Permalink

Manikumar added a comment - 05/Oct/14 05:42

Updated reviewboard https://reviews.apache.org/r/26348/diff/
against branch origin/trunk

Show

Manikumar added a comment - 05/Oct/14 05:42 Updated reviewboard https://reviews.apache.org/r/26348/diff/ against branch origin/trunk

Hide

Permalink

Manikumar added a comment - 05/Oct/14 05:43

Updated reviewboard https://reviews.apache.org/r/26348/diff/
against branch origin/trunk

Show

Manikumar added a comment - 05/Oct/14 05:43 Updated reviewboard https://reviews.apache.org/r/26348/diff/ against branch origin/trunk

Hide

Permalink

Manikumar added a comment - 05/Oct/14 05:47

Created reviewboard https://reviews.apache.org/r/26349/diff/
against branch origin/trunk

Show

Manikumar added a comment - 05/Oct/14 05:47 Created reviewboard https://reviews.apache.org/r/26349/diff/ against branch origin/trunk

Hide

Permalink

Manikumar added a comment - 05/Oct/14 05:51

Updated reviewboard https://reviews.apache.org/r/26349/diff/
against branch origin/trunk

Show

Manikumar added a comment - 05/Oct/14 05:51 Updated reviewboard https://reviews.apache.org/r/26349/diff/ against branch origin/trunk

Hide

Permalink

Manikumar added a comment - 05/Oct/14 05:58

Neha Narkhede What is the version of your rbt tool?
I am using RBTools 0.6.2

$ rbt --version
RBTools 0.6.2

I uploaded a new patch, which should work with older version of rbt.
Can you try the latest patch?

Show

Manikumar added a comment - 05/Oct/14 05:58 Neha Narkhede What is the version of your rbt tool? I am using RBTools 0.6.2 $ rbt --version RBTools 0.6.2 I uploaded a new patch, which should work with older version of rbt. Can you try the latest patch?

Hide

Permalink

Neha Narkhede added a comment - 12/Oct/14 23:47

Manikumar Tried your latest patch.

nnarkhed-mn1:kafka nnarkhed$ python kafka-patch-review.py -j KAFKA-1277 -b trunk -d "test"
Configuring reviewboard url to https://reviews.apache.org
Updating your remote branches to pull the latest changes
Usage: rbt post [options] [changenum]

Uploads diffs to create and update review requests.

rbt: error: no such option: -a
ERROR: reviewboard update failed. Exiting.
nnarkhed-mn1:kafka nnarkhed$ rbt --version
RBTools 0.5.2

Show

Neha Narkhede added a comment - 12/Oct/14 23:47 Manikumar Tried your latest patch. nnarkhed-mn1:kafka nnarkhed$ python kafka-patch-review.py -j KAFKA-1277 -b trunk -d "test" Configuring reviewboard url to https://reviews.apache.org Updating your remote branches to pull the latest changes Usage: rbt post [options] [changenum] Uploads diffs to create and update review requests. rbt: error: no such option: -a ERROR: reviewboard update failed. Exiting. nnarkhed-mn1:kafka nnarkhed$ rbt --version RBTools 0.5.2

Hide

Permalink

Neha Narkhede added a comment - 26/Apr/15 16:25

Closing due to inactivity.

Show

Neha Narkhede added a comment - 26/Apr/15 16:25 Closing due to inactivity.

People

Assignee:

Manikumar

Reporter:

Guozhang Wang

Reviewer:

Neha Narkhede

Votes:

0 Vote for this issue

Watchers:

3 Start watching this issue

Dates

Created:

20/Feb/14 21:09

Updated:

26/Apr/15 16:25

Resolved:

26/Apr/15 16:25

Development

Agile

View on Board