Details
-
Type:
Bug
-
Status: Patch Available
-
Priority:
Major
-
Resolution: Unresolved
-
Affects Version/s: None
-
Fix Version/s: None
-
Component/s: None
-
Labels:None
Description
Today kafka-patch-review tool will always use a default title and description if they are not specified, even when updating an existing RB. Would better change to leave the current title/description as is.
Activity
Updated reviewboard https://reviews.apache.org/r/26340/diff/
against branch origin/trunk
Updated reviewboard https://reviews.apache.org/r/26340/diff/
against branch origin/trunk
Updated reviewboard https://reviews.apache.org/r/26340/diff/
against branch origin/trunk
Updated reviewboard https://reviews.apache.org/r/26340/diff/
against branch origin/trunk
Updated reviewboard https://reviews.apache.org/r/26340/diff/
against branch origin/trunk
Updated reviewboard https://reviews.apache.org/r/26340/diff/
against branch origin/trunk
Updated reviewboard https://reviews.apache.org/r/26340/diff/
against branch origin/trunk
In this patch, I disabled the auto-setting of Summary and Description fields of RB request. Unless explicitly set, these fields will not get updated for existing RBs..
Manikumar Reddy I tried testing the patch, but it failed with the following error
nnarkhed-mn1:kafka-git-idea nnarkhed$ python kafka-patch-review.py -j KAFKA-1277 -b trunk Configuring reviewboard url to https://reviews.apache.org Updating your remote branches to pull the latest changes Usage: rbt post [options] [changenum] Uploads diffs to create and update review requests. rbt: error: --guess-fields option does not take a value ERROR: reviewboard update failed. Exiting.
Created reviewboard https://reviews.apache.org/r/26348/diff/
against branch origin/trunk
Updated reviewboard https://reviews.apache.org/r/26348/diff/
against branch origin/trunk
Updated reviewboard https://reviews.apache.org/r/26348/diff/
against branch origin/trunk
Updated reviewboard https://reviews.apache.org/r/26348/diff/
against branch origin/trunk
Created reviewboard https://reviews.apache.org/r/26349/diff/
against branch origin/trunk
Updated reviewboard https://reviews.apache.org/r/26349/diff/
against branch origin/trunk
Neha Narkhede What is the version of your rbt tool?
I am using RBTools 0.6.2
$ rbt --version
RBTools 0.6.2
I uploaded a new patch, which should work with older version of rbt.
Can you try the latest patch?
Manikumar Reddy Tried your latest patch.
nnarkhed-mn1:kafka nnarkhed$ python kafka-patch-review.py -j KAFKA-1277 -b trunk -d "test" Configuring reviewboard url to https://reviews.apache.org Updating your remote branches to pull the latest changes Usage: rbt post [options] [changenum] Uploads diffs to create and update review requests. rbt: error: no such option: -a ERROR: reviewboard update failed. Exiting. nnarkhed-mn1:kafka nnarkhed$ rbt --version RBTools 0.5.2
Created reviewboard https://reviews.apache.org/r/26340/diff/
against branch origin/trunk