Kafka
  1. Kafka
  2. KAFKA-1277

Keep the summery/description when updating the RB with kafka-patch-review

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Incomplete
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      Today kafka-patch-review tool will always use a default title and description if they are not specified, even when updating an existing RB. Would better change to leave the current title/description as is.

      1. KAFKA-1277.patch
        0.9 kB
        Manikumar Reddy
      2. KAFKA-1277.patch
        1 kB
        Manikumar Reddy
      3. KAFKA-1277.patch
        1 kB
        Manikumar Reddy
      4. KAFKA-1277_2014-10-05_11:18:17.patch
        1 kB
        Manikumar Reddy
      5. KAFKA-1277_2014-10-05_11:10:50.patch
        1 kB
        Manikumar Reddy
      6. KAFKA-1277_2014-10-05_11:09:08.patch
        1 kB
        Manikumar Reddy
      7. KAFKA-1277_2014-10-05_11:04:33.patch
        1 kB
        Manikumar Reddy
      8. KAFKA-1277_2014-10-04_17:09:02.patch
        1 kB
        Manikumar Reddy
      9. KAFKA-1277_2014-10-04_17:03:08.patch
        1 kB
        Manikumar Reddy
      10. KAFKA-1277_2014-10-04_17:01:43.patch
        1 kB
        Manikumar Reddy
      11. KAFKA-1277_2014-10-04_17:00:37.patch
        1 kB
        Manikumar Reddy
      12. KAFKA-1277_2014-10-04_16:57:30.patch
        0.9 kB
        Manikumar Reddy
      13. KAFKA-1277_2014-10-04_16:51:20.patch
        0.9 kB
        Manikumar Reddy
      14. KAFKA-1277_2014-10-04_16:39:56.patch
        0.9 kB
        Manikumar Reddy

        Activity

        Hide
        Manikumar Reddy added a comment -

        Created reviewboard https://reviews.apache.org/r/26340/diff/
        against branch origin/trunk

        Show
        Manikumar Reddy added a comment - Created reviewboard https://reviews.apache.org/r/26340/diff/ against branch origin/trunk
        Hide
        Manikumar Reddy added a comment -

        Updated reviewboard https://reviews.apache.org/r/26340/diff/
        against branch origin/trunk

        Show
        Manikumar Reddy added a comment - Updated reviewboard https://reviews.apache.org/r/26340/diff/ against branch origin/trunk
        Hide
        Manikumar Reddy added a comment -

        Updated reviewboard https://reviews.apache.org/r/26340/diff/
        against branch origin/trunk

        Show
        Manikumar Reddy added a comment - Updated reviewboard https://reviews.apache.org/r/26340/diff/ against branch origin/trunk
        Hide
        Manikumar Reddy added a comment -

        Updated reviewboard https://reviews.apache.org/r/26340/diff/
        against branch origin/trunk

        Show
        Manikumar Reddy added a comment - Updated reviewboard https://reviews.apache.org/r/26340/diff/ against branch origin/trunk
        Hide
        Manikumar Reddy added a comment -

        Updated reviewboard https://reviews.apache.org/r/26340/diff/
        against branch origin/trunk

        Show
        Manikumar Reddy added a comment - Updated reviewboard https://reviews.apache.org/r/26340/diff/ against branch origin/trunk
        Hide
        Manikumar Reddy added a comment -

        Updated reviewboard https://reviews.apache.org/r/26340/diff/
        against branch origin/trunk

        Show
        Manikumar Reddy added a comment - Updated reviewboard https://reviews.apache.org/r/26340/diff/ against branch origin/trunk
        Hide
        Manikumar Reddy added a comment -

        Updated reviewboard https://reviews.apache.org/r/26340/diff/
        against branch origin/trunk

        Show
        Manikumar Reddy added a comment - Updated reviewboard https://reviews.apache.org/r/26340/diff/ against branch origin/trunk
        Hide
        Manikumar Reddy added a comment -

        Updated reviewboard https://reviews.apache.org/r/26340/diff/
        against branch origin/trunk

        Show
        Manikumar Reddy added a comment - Updated reviewboard https://reviews.apache.org/r/26340/diff/ against branch origin/trunk
        Hide
        Manikumar Reddy added a comment -

        In this patch, I disabled the auto-setting of Summary and Description fields of RB request. Unless explicitly set, these fields will not get updated for existing RBs..

        Show
        Manikumar Reddy added a comment - In this patch, I disabled the auto-setting of Summary and Description fields of RB request. Unless explicitly set, these fields will not get updated for existing RBs..
        Hide
        Neha Narkhede added a comment -

        Manikumar Reddy I tried testing the patch, but it failed with the following error

        nnarkhed-mn1:kafka-git-idea nnarkhed$ python kafka-patch-review.py -j KAFKA-1277 -b trunk
        Configuring reviewboard url to https://reviews.apache.org
        Updating your remote branches to pull the latest changes
        Usage: rbt post [options] [changenum]
        
        Uploads diffs to create and update review requests.
        
        rbt: error: --guess-fields option does not take a value
        ERROR: reviewboard update failed. Exiting.
        
        Show
        Neha Narkhede added a comment - Manikumar Reddy I tried testing the patch, but it failed with the following error nnarkhed-mn1:kafka-git-idea nnarkhed$ python kafka-patch-review.py -j KAFKA-1277 -b trunk Configuring reviewboard url to https://reviews.apache.org Updating your remote branches to pull the latest changes Usage: rbt post [options] [changenum] Uploads diffs to create and update review requests. rbt: error: --guess-fields option does not take a value ERROR: reviewboard update failed. Exiting.
        Hide
        Manikumar Reddy added a comment -

        Created reviewboard https://reviews.apache.org/r/26348/diff/
        against branch origin/trunk

        Show
        Manikumar Reddy added a comment - Created reviewboard https://reviews.apache.org/r/26348/diff/ against branch origin/trunk
        Hide
        Manikumar Reddy added a comment -

        Updated reviewboard https://reviews.apache.org/r/26348/diff/
        against branch origin/trunk

        Show
        Manikumar Reddy added a comment - Updated reviewboard https://reviews.apache.org/r/26348/diff/ against branch origin/trunk
        Hide
        Manikumar Reddy added a comment -

        Updated reviewboard https://reviews.apache.org/r/26348/diff/
        against branch origin/trunk

        Show
        Manikumar Reddy added a comment - Updated reviewboard https://reviews.apache.org/r/26348/diff/ against branch origin/trunk
        Hide
        Manikumar Reddy added a comment -

        Updated reviewboard https://reviews.apache.org/r/26348/diff/
        against branch origin/trunk

        Show
        Manikumar Reddy added a comment - Updated reviewboard https://reviews.apache.org/r/26348/diff/ against branch origin/trunk
        Hide
        Manikumar Reddy added a comment -

        Created reviewboard https://reviews.apache.org/r/26349/diff/
        against branch origin/trunk

        Show
        Manikumar Reddy added a comment - Created reviewboard https://reviews.apache.org/r/26349/diff/ against branch origin/trunk
        Hide
        Manikumar Reddy added a comment -

        Updated reviewboard https://reviews.apache.org/r/26349/diff/
        against branch origin/trunk

        Show
        Manikumar Reddy added a comment - Updated reviewboard https://reviews.apache.org/r/26349/diff/ against branch origin/trunk
        Hide
        Manikumar Reddy added a comment -

        Neha Narkhede What is the version of your rbt tool?
        I am using RBTools 0.6.2

        $ rbt --version
        RBTools 0.6.2

        I uploaded a new patch, which should work with older version of rbt.
        Can you try the latest patch?

        Show
        Manikumar Reddy added a comment - Neha Narkhede What is the version of your rbt tool? I am using RBTools 0.6.2 $ rbt --version RBTools 0.6.2 I uploaded a new patch, which should work with older version of rbt. Can you try the latest patch?
        Hide
        Neha Narkhede added a comment -

        Manikumar Reddy Tried your latest patch.

        nnarkhed-mn1:kafka nnarkhed$ python kafka-patch-review.py -j KAFKA-1277 -b trunk -d "test"
        Configuring reviewboard url to https://reviews.apache.org
        Updating your remote branches to pull the latest changes
        Usage: rbt post [options] [changenum]
        
        Uploads diffs to create and update review requests.
        
        rbt: error: no such option: -a
        ERROR: reviewboard update failed. Exiting.
        nnarkhed-mn1:kafka nnarkhed$ rbt --version
        RBTools 0.5.2
        
        Show
        Neha Narkhede added a comment - Manikumar Reddy Tried your latest patch. nnarkhed-mn1:kafka nnarkhed$ python kafka-patch-review.py -j KAFKA-1277 -b trunk -d "test" Configuring reviewboard url to https://reviews.apache.org Updating your remote branches to pull the latest changes Usage: rbt post [options] [changenum] Uploads diffs to create and update review requests. rbt: error: no such option: -a ERROR: reviewboard update failed. Exiting. nnarkhed-mn1:kafka nnarkhed$ rbt --version RBTools 0.5.2
        Hide
        Neha Narkhede added a comment -

        Closing due to inactivity.

        Show
        Neha Narkhede added a comment - Closing due to inactivity.

          People

          • Assignee:
            Manikumar Reddy
            Reporter:
            Guozhang Wang
            Reviewer:
            Neha Narkhede
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development