[KAFKA-126] Log flush should complete upon broker shutdown

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.7
• Assignee: Unassigned
• Reporter: Joel Jacob Koshy
• Created: 31/Aug/11 23:58
• Updated: 05/Oct/11 23:05
• Resolved: 26/Sep/11 17:35

Description

Broker shutdown currently forces the flush scheduler to shutdown(Now). This leads to an unclean shutdown. cleanupLogs may be affected by a similar scenario.

2011/08/31 09:45:34.833 ERROR [LogManager] [kafka-logflusher-0] [kafka] Error flushing topic MyTopic
java.nio.channels.ClosedByInterruptException
at java.nio.channels.spi.AbstractInterruptibleChannel.end(AbstractInterruptibleChannel.java:184)
at sun.nio.ch.FileChannelImpl.force(FileChannelImpl.java:362)
at kafka.message.FileMessageSet.flush(FileMessageSet.scala:174)
at kafka.log.Log.flush(Log.scala:306)
at kafka.log.LogManager$$anonfun$kafka$log$LogManager$$flushAllLogs$1.apply(LogManager.scala:274)
at kafka.log.LogManager$$anonfun$kafka$log$LogManager$$flushAllLogs$1.apply(LogManager.scala:263)
at scala.collection.Iterator$class.foreach(Iterator.scala:631)
at kafka.utils.IteratorTemplate.foreach(IteratorTemplate.scala:30)
at kafka.log.LogManager.kafka$log$LogManager$$flushAllLogs(LogManager.scala:263)
at kafka.log.LogManager$$anonfun$startup$1.apply$mcV$sp(LogManager.scala:129)
at kafka.utils.Utils$$anon$2.run(Utils.scala:58)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441)
at java.util.concurrent.FutureTask$Sync.innerRunAndReset(FutureTask.java:317)
at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:150)
at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$101(ScheduledThreadPoolExecutor.java:98)
at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.runPeriodic(ScheduledThreadPoolExecutor.java:181)
at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:205)
at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
at java.lang.Thread.run(Thread.java:619)

A possible fix this would be to use shutdown() instead of shutdownNow() in the scheduler.

Issue Links

• is duplicated by: KAFKA-148 Shutdown During a Log Flush Throws Exception, Triggers Startup in Recovery Mode