Kafka
  1. Kafka
  2. KAFKA-1239 New producer checklist
  3. KAFKA-1259

Producer close function no longer block until all messages be sent

    Details

    • Type: Sub-task Sub-task
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: producer
    • Labels:
      None

      Description

      The testClose currently breaks since

      assertTrue("The last message should be acked before producer is shutdown", response0.isDone)

      fails, it was fine before some commits on 2/10.

        Activity

        Hide
        Jay Kreps added a comment -

        Created reviewboard https://reviews.apache.org/r/17973/
        against branch trunk

        Show
        Jay Kreps added a comment - Created reviewboard https://reviews.apache.org/r/17973/ against branch trunk
        Hide
        Jay Kreps added a comment -

        The logic we had was to block until all requests were sent but not until all responses were received (which is wrong). Not sure why that test passed before, but I confirmed that this fixes it.

        Show
        Jay Kreps added a comment - The logic we had was to block until all requests were sent but not until all responses were received (which is wrong). Not sure why that test passed before, but I confirmed that this fixes it.

          People

          • Assignee:
            Jay Kreps
            Reporter:
            Guozhang Wang
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development