Details

    • Type: Sub-task Sub-task
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: producer
    • Labels:
      None

      Description

      Currently there is no logging in the client.

      1. kafka_debug.txt
        2 kB
        Jay Kreps
      2. kafka_trace.txt
        108 kB
        Jay Kreps
      3. KAFKA-1250_2014-02-25_21:31:44.patch
        49 kB
        Jay Kreps
      4. KAFKA-1250_2014-02-26_18:32:24.patch
        49 kB
        Jay Kreps
      5. KAFKA-1250.patch
        37 kB
        Jay Kreps

        Activity

        Hide
        Jay Kreps added a comment -

        Created reviewboard https://reviews.apache.org/r/18343/
        against branch trunk

        Show
        Jay Kreps added a comment - Created reviewboard https://reviews.apache.org/r/18343/ against branch trunk
        Hide
        Jay Kreps added a comment -

        Updated reviewboard against branch trunk

        Show
        Jay Kreps added a comment - Updated reviewboard against branch trunk
        Hide
        Jay Kreps added a comment -

        Updated reviewboard https://reviews.apache.org/r/18343/
        against branch trunk

        Show
        Jay Kreps added a comment - Updated reviewboard https://reviews.apache.org/r/18343/ against branch trunk
        Hide
        Jay Kreps added a comment -

        Okay guys, I have capitulated on the config logging thing. I really think this is a nasty inelegant thing to do and we should not do it, but I think we need to make progress.

        Since it sounds like people weren't actually looking at logging output but rather just spot checking log statements. I think it is hard to get a sense of the output this way. I think the more important thing is to look at the logging output. To help people do this I have included the output at TRACE and DEBUG levels.

        The general idea is that this should tell the rough story of what has transpired. One can always log more but I think adding lower value log statements actually is a net negative as it obscures more important things.

        At a high level I am following the logging guidelines in the coding standard but with the assumption that in the client what the client generally wants is the response or exception and logging is more of a tracing facility.

        Show
        Jay Kreps added a comment - Okay guys, I have capitulated on the config logging thing. I really think this is a nasty inelegant thing to do and we should not do it, but I think we need to make progress. Since it sounds like people weren't actually looking at logging output but rather just spot checking log statements. I think it is hard to get a sense of the output this way. I think the more important thing is to look at the logging output. To help people do this I have included the output at TRACE and DEBUG levels. The general idea is that this should tell the rough story of what has transpired. One can always log more but I think adding lower value log statements actually is a net negative as it obscures more important things. At a high level I am following the logging guidelines in the coding standard but with the assumption that in the client what the client generally wants is the response or exception and logging is more of a tracing facility.

          People

          • Assignee:
            Jay Kreps
            Reporter:
            Jay Kreps
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development