Uploaded image for project: 'Kafka'
  1. Kafka
  2. KAFKA-124

Console consumer does not exit if consuming process dies

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.6, 0.7
    • Fix Version/s: 0.7
    • Component/s: None
    • Labels:
      None

      Description

      Running the kafka console consumer it should be the case that if the consuming subprocess dies the java process dies as well. Instead it continues consuming messages even though there is no one to give them to.

        Activity

        Hide
        jjkoshy Joel Koshy added a comment -

        +1

        PrintStream javadoc suggests that System.out.flush() is redundant, since checkError also does a flush. Per our coding conventions since checkError has that side-effect, optional parentheses would be appropriate for that call.

        Show
        jjkoshy Joel Koshy added a comment - +1 PrintStream javadoc suggests that System.out.flush() is redundant, since checkError also does a flush. Per our coding conventions since checkError has that side-effect, optional parentheses would be appropriate for that call.
        Hide
        junrao Jun Rao added a comment -

        the patch looks good to me. +1 please fix the indentation before checking in.

        Show
        junrao Jun Rao added a comment - the patch looks good to me. +1 please fix the indentation before checking in.
        Hide
        bmatheny Blake Matheny added a comment -

        Appreciate the comment cleanup. The System.out.flush() line looks like it has a different indentation level than the other lines in the same block. Everything else looks good. Not sure if a +1 is required from Kafka devs or not but it has my vote.

        Show
        bmatheny Blake Matheny added a comment - Appreciate the comment cleanup. The System.out.flush() line looks like it has a different indentation level than the other lines in the same block. Everything else looks good. Not sure if a +1 is required from Kafka devs or not but it has my vote.
        Hide
        jkreps Jay Kreps added a comment -

        Can a brother get a +1?

        Show
        jkreps Jay Kreps added a comment - Can a brother get a +1?

          People

          • Assignee:
            jkreps Jay Kreps
            Reporter:
            jkreps Jay Kreps
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development