[KAFKA-12333] KafkaMetadataLog and MockLock should validate that appended epochs are monotonically

• Type: Sub-task
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Component/s: replication
• Assignee: HaiyuanZhao
• Reporter: José Armando García Sancio
• Created: 17/Feb/21 19:47
• Updated: 25/Nov/21 00:40

Description

Both the MockLog and KafkaMetadataLog should only allow appendAsLeader and appendAsFollower with monotonically increasing epochs. In other words the following test in KafkaMetadataLogTest should fail:

  @Test
  def testOutOfOrderEpoch(): Unit = {
    val topicPartition = new TopicPartition("cluster-metadata", 0)
    val log = buildMetadataLog(tempDir, mockTime, topicPartition)    val recordFoo = new SimpleRecord("foo".getBytes())
    val currentEpoch = 3
    val initialOffset = log.endOffset().offset    log.appendAsLeader(
      MemoryRecords.withRecords(initialOffset, CompressionType.NONE, currentEpoch, recordFoo),
      currentEpoch
    )    // Out order epoch should throw an exception
    log.appendAsLeader(
      MemoryRecords.withRecords(
        initialOffset + 1, CompressionType.NONE, currentEpoch - 1, recordFoo
      ),
      currentEpoch - 1
    )
    log.appendAsFollower(
      MemoryRecords.withRecords(
        initialOffset + 2, CompressionType.NONE, currentEpoch - 2, recordFoo
      )
    )
  } 

The same for MockLogTest.

Issue Links

• links to: GitHub Pull Request #11015