Kafka
  1. Kafka
  2. KAFKA-120

Code clean up in FetcherRunnable and ZookeeperConsumerConnector

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.7
    • Fix Version/s: 0.7
    • Component/s: None
    • Labels:
      None

      Description

      Add more logging info and remove unused code.

      1. kafka-120_v2.patch
        3 kB
        Jun Rao
      2. kafka-120.patch
        3 kB
        Jun Rao

        Activity

        Hide
        Jun Rao added a comment -

        patch attached.

        Show
        Jun Rao added a comment - patch attached.
        Hide
        Neha Narkhede added a comment -

        There is a problem with using the logger.warn(Throwable) API. It won't log the entire stack trace of the error. You will need to use the logger.warn("custom message", Throwable) API to be able to log the entire stack trace

        Show
        Neha Narkhede added a comment - There is a problem with using the logger.warn(Throwable) API. It won't log the entire stack trace of the error. You will need to use the logger.warn("custom message", Throwable) API to be able to log the entire stack trace
        Hide
        Jun Rao added a comment -

        Fixed the issue. Loaded patch v2.

        Show
        Jun Rao added a comment - Fixed the issue. Loaded patch v2.
        Hide
        Neha Narkhede added a comment -

        +1.
        Looks good.

        Show
        Neha Narkhede added a comment - +1. Looks good.

          People

          • Assignee:
            Jun Rao
            Reporter:
            Jun Rao
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development