Uploaded image for project: 'Kafka'
  1. Kafka
  2. KAFKA-1135

Code cleanup - use Json.encode() to write json data to zk

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.8.1
    • Component/s: None
    • Labels:
      None
    1. KAFKA-1135.patch
      27 kB
      Swapnil Ghike
    2. KAFKA-1135_2013-11-18_19:17:54.patch
      27 kB
      Swapnil Ghike
    3. KAFKA-1135_2013-11-18_19:20:58.patch
      27 kB
      Swapnil Ghike

      Activity

      Hide
      swapnilghike Swapnil Ghike added a comment -

      Created reviewboard https://reviews.apache.org/r/15665/
      against branch origin/trunk

      Show
      swapnilghike Swapnil Ghike added a comment - Created reviewboard https://reviews.apache.org/r/15665/ against branch origin/trunk
      Hide
      swapnilghike Swapnil Ghike added a comment -

      Updated reviewboard https://reviews.apache.org/r/15665/
      against branch origin/trunk

      Show
      swapnilghike Swapnil Ghike added a comment - Updated reviewboard https://reviews.apache.org/r/15665/ against branch origin/trunk
      Hide
      swapnilghike Swapnil Ghike added a comment -

      Updated reviewboard https://reviews.apache.org/r/15665/
      against branch origin/trunk

      Show
      swapnilghike Swapnil Ghike added a comment - Updated reviewboard https://reviews.apache.org/r/15665/ against branch origin/trunk
      Hide
      junrao Jun Rao added a comment -

      Thanks for the patch. +1 and committed to trunk.

      Show
      junrao Jun Rao added a comment - Thanks for the patch. +1 and committed to trunk.
      Hide
      davidlao David Lao added a comment -

      Hi. This patch seem to have undone all the KAFKA-1112 changes. Can you verify?

      Show
      davidlao David Lao added a comment - Hi. This patch seem to have undone all the KAFKA-1112 changes. Can you verify?
      Hide
      swapnilghike Swapnil Ghike added a comment -

      Thanks for catching this David! Jun, it seems that the diff in the reviewboard and what got attached to this JIRA is different. Can you please revert commit 9b0776d157afd9eacddb84a99f2420fa9c0d505b, download the diff from the reviewboard and commit it?

      Show
      swapnilghike Swapnil Ghike added a comment - Thanks for catching this David! Jun, it seems that the diff in the reviewboard and what got attached to this JIRA is different. Can you please revert commit 9b0776d157afd9eacddb84a99f2420fa9c0d505b, download the diff from the reviewboard and commit it?
      Hide
      swapnilghike Swapnil Ghike added a comment -

      Joel Koshy, does the above issue look similar to KAFKA-1142?

      Show
      swapnilghike Swapnil Ghike added a comment - Joel Koshy , does the above issue look similar to KAFKA-1142 ?
      Hide
      junrao Jun Rao added a comment -

      Thanks for pointing this out. Recommitted KAFKA-1112.

      Show
      junrao Jun Rao added a comment - Thanks for pointing this out. Recommitted KAFKA-1112 .
      Hide
      jjkoshy Joel Koshy added a comment -

      Swapnil Ghike I'm pretty sure the extra diff comes due to the issue in KAFKA-1142, but I don't know why that change does not show up in the RB itself.

      Show
      jjkoshy Joel Koshy added a comment - Swapnil Ghike I'm pretty sure the extra diff comes due to the issue in KAFKA-1142 , but I don't know why that change does not show up in the RB itself.

        People

        • Assignee:
          swapnilghike Swapnil Ghike
          Reporter:
          swapnilghike Swapnil Ghike
        • Votes:
          0 Vote for this issue
          Watchers:
          4 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development