Kafka
  1. Kafka
  2. KAFKA-112

Improve the command line tools in the bin directory to use the compression feature correctly

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.7
    • Fix Version/s: 0.7
    • Component/s: None
    • Labels:
      None

      Description

      This ticket is filed to improve various command line tools -

      1. All tools need to use the new Iterator API for ByteBufferMessageSet that returns MessageAndOffset
      2. A bug in ProducerPerformance does not set the compression codec correctly.
      3. The simple consumer shell lacks some useful command line options and needs better logging

      1. KAFKA-112.patch
        5 kB
        Neha Narkhede
      2. KAFKA-112.patch
        5 kB
        Neha Narkhede

        Activity

        Neha Narkhede created issue -
        Neha Narkhede made changes -
        Field Original Value New Value
        Description This ticket is filed to improve various command line tools -

        1. The command line tools are still using the older Iterator API of the ByteBufferMessageSet.
        2. A bug in ProducerPerformance does not set the compression codec correctly.
        3. The simple consumer shell lacks some useful command line options and needs better logging
        4. All tools need to use the new Iterator API for ByteBufferMessageSet that returns MessageAndOffset
        This ticket is filed to improve various command line tools -

        1. All tools need to use the new Iterator API for ByteBufferMessageSet that returns MessageAndOffset
        2. A bug in ProducerPerformance does not set the compression codec correctly.
        3. The simple consumer shell lacks some useful command line options and needs better logging

        Neha Narkhede made changes -
        Attachment KAFKA-112.patch [ 12490860 ]
        Neha Narkhede made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Jun Rao added a comment -

        1. DumpLogSegments currently returns the absolute offset, which is ideal. With the patch, it returns relative offset within a file. This will be confusing if a file starts at an offset other than 0.
        2. The patch doesn't seem to apply on trunk. Could you rebase?

        Show
        Jun Rao added a comment - 1. DumpLogSegments currently returns the absolute offset, which is ideal. With the patch, it returns relative offset within a file. This will be confusing if a file starts at an offset other than 0. 2. The patch doesn't seem to apply on trunk. Could you rebase?
        Hide
        Neha Narkhede added a comment -

        Jun,

        That makes sense. I reverted that change to the DumpLogSegments utility.

        Thanks,
        Neha

        Show
        Neha Narkhede added a comment - Jun, That makes sense. I reverted that change to the DumpLogSegments utility. Thanks, Neha
        Neha Narkhede made changes -
        Attachment KAFKA-112.patch [ 12490898 ]
        Hide
        Jun Rao added a comment -

        The patch looks good. The patch doesn't apply because you moved DumpLogSegment from the util to tools (which is good).

        Show
        Jun Rao added a comment - The patch looks good. The patch doesn't apply because you moved DumpLogSegment from the util to tools (which is good).
        Jun Rao made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Fix Version/s 0.7 [ 12317243 ]
        Resolution Fixed [ 1 ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Neha Narkhede
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development