Kafka
  1. Kafka
  2. KAFKA-112

Improve the command line tools in the bin directory to use the compression feature correctly

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.7
    • Fix Version/s: 0.7
    • Component/s: None
    • Labels:
      None

      Description

      This ticket is filed to improve various command line tools -

      1. All tools need to use the new Iterator API for ByteBufferMessageSet that returns MessageAndOffset
      2. A bug in ProducerPerformance does not set the compression codec correctly.
      3. The simple consumer shell lacks some useful command line options and needs better logging

      1. KAFKA-112.patch
        5 kB
        Neha Narkhede
      2. KAFKA-112.patch
        5 kB
        Neha Narkhede

        Activity

        Hide
        Jun Rao added a comment -

        1. DumpLogSegments currently returns the absolute offset, which is ideal. With the patch, it returns relative offset within a file. This will be confusing if a file starts at an offset other than 0.
        2. The patch doesn't seem to apply on trunk. Could you rebase?

        Show
        Jun Rao added a comment - 1. DumpLogSegments currently returns the absolute offset, which is ideal. With the patch, it returns relative offset within a file. This will be confusing if a file starts at an offset other than 0. 2. The patch doesn't seem to apply on trunk. Could you rebase?
        Hide
        Neha Narkhede added a comment -

        Jun,

        That makes sense. I reverted that change to the DumpLogSegments utility.

        Thanks,
        Neha

        Show
        Neha Narkhede added a comment - Jun, That makes sense. I reverted that change to the DumpLogSegments utility. Thanks, Neha
        Hide
        Jun Rao added a comment -

        The patch looks good. The patch doesn't apply because you moved DumpLogSegment from the util to tools (which is good).

        Show
        Jun Rao added a comment - The patch looks good. The patch doesn't apply because you moved DumpLogSegment from the util to tools (which is good).

          People

          • Assignee:
            Unassigned
            Reporter:
            Neha Narkhede
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development