Uploaded image for project: 'Kafka'
  1. Kafka
  2. KAFKA-1117

tool for checking the consistency among replicas

    Details

    • Type: New Feature
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.8.1
    • Fix Version/s: 0.8.1
    • Component/s: core
    • Labels:
      None
    1. KAFKA-1117_2013-11-11_08:44:25.patch
      18 kB
      Jun Rao
    2. KAFKA-1117_2013-11-12_08:34:53.patch
      20 kB
      Jun Rao
    3. KAFKA-1117_2013-11-14_08:24:41.patch
      19 kB
      Jun Rao
    4. KAFKA-1117_2013-11-18_09:58:23.patch
      19 kB
      Jun Rao
    5. KAFKA-1117.patch
      59 kB
      Jun Rao

      Activity

      Hide
      junrao Jun Rao added a comment -
      Show
      junrao Jun Rao added a comment - Created reviewboard https://reviews.apache.org/r/15201/
      Hide
      junrao Jun Rao added a comment -

      Updated reviewboard https://reviews.apache.org/r/15201/
      against branch origin/trunk

      Show
      junrao Jun Rao added a comment - Updated reviewboard https://reviews.apache.org/r/15201/ against branch origin/trunk
      Hide
      junrao Jun Rao added a comment -

      Updated reviewboard https://reviews.apache.org/r/15201/
      against branch origin/trunk

      Show
      junrao Jun Rao added a comment - Updated reviewboard https://reviews.apache.org/r/15201/ against branch origin/trunk
      Hide
      junrao Jun Rao added a comment -

      Updated reviewboard https://reviews.apache.org/r/15201/
      against branch origin/trunk

      Show
      junrao Jun Rao added a comment - Updated reviewboard https://reviews.apache.org/r/15201/ against branch origin/trunk
      Hide
      junrao Jun Rao added a comment -

      Updated reviewboard https://reviews.apache.org/r/15201/
      against branch origin/trunk

      Show
      junrao Jun Rao added a comment - Updated reviewboard https://reviews.apache.org/r/15201/ against branch origin/trunk
      Hide
      junrao Jun Rao added a comment -

      Thanks for the reviews. Committed to trunk.

      Show
      junrao Jun Rao added a comment - Thanks for the reviews. Committed to trunk.
      Hide
      swapnilghike Swapnil Ghike added a comment -

      Hey Jun, after committing this patch, builds with scala 2.10.* are breaking, could you please take a look:

      [error] /home/sghike/kafka-server/kafka-server_trunk/kafka/core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala:364: ambiguous reference to overloaded definition,
      [error] both constructor FetchResponsePartitionData in class FetchResponsePartitionData of type (messages: kafka.message.MessageSet)kafka.api.FetchResponsePartitionData
      [error] and constructor FetchResponsePartitionData in class FetchResponsePartitionData of type (error: Short, hw: Long, messages: kafka.message.MessageSet)kafka.api.FetchResponsePartitionData
      [error] match argument types (messages: kafka.message.ByteBufferMessageSet) and expected result type kafka.api.FetchResponsePartitionData
      [error] replicaBuffer.addFetchedData(topicAndPartition, sourceBroker.id, new FetchResponsePartitionData(messages = MessageSet.Empty))
      [error]

      Show
      swapnilghike Swapnil Ghike added a comment - Hey Jun, after committing this patch, builds with scala 2.10.* are breaking, could you please take a look: [error] /home/sghike/kafka-server/kafka-server_trunk/kafka/core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala:364: ambiguous reference to overloaded definition, [error] both constructor FetchResponsePartitionData in class FetchResponsePartitionData of type (messages: kafka.message.MessageSet)kafka.api.FetchResponsePartitionData [error] and constructor FetchResponsePartitionData in class FetchResponsePartitionData of type (error: Short, hw: Long, messages: kafka.message.MessageSet)kafka.api.FetchResponsePartitionData [error] match argument types (messages: kafka.message.ByteBufferMessageSet) and expected result type kafka.api.FetchResponsePartitionData [error] replicaBuffer.addFetchedData(topicAndPartition, sourceBroker.id, new FetchResponsePartitionData(messages = MessageSet.Empty)) [error]
      Hide
      junrao Jun Rao added a comment -

      This is resolved now. It seems that unit tests were already broken because of this issue. It's just that we never run unit tests under 2.10.1.

      Show
      junrao Jun Rao added a comment - This is resolved now. It seems that unit tests were already broken because of this issue. It's just that we never run unit tests under 2.10.1.

        People

        • Assignee:
          junrao Jun Rao
          Reporter:
          junrao Jun Rao
        • Votes:
          0 Vote for this issue
          Watchers:
          2 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development