[KAFKA-10899] Closing check Before Producer's BufferPool allocat memory

• Type: Improvement
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 2.8.0
• Component/s: producer
• External issue URL: https://github.com/apache/kafka/pull/9817
• Assignee: Unassigned
• Reporter: lizhao
• Created: 04/Jan/21 11:30
• Updated: 07/Jan/21 06:35

Description

#9817   Closing check Before Producer's BufferPool allocat memory

According to the idea of #7967, it made BufferPool support closing.
Now, there are two places in the BufferPool#allocate() method to judge the 'closed' flag. One is when 'lock' is acquired, and the other is when 'condition' is awakened.

However, if the memory is allocated outside the 'lock' code block after 'freeup',
Therefore, it is possible for another thread to modify the 'closed' flag, causing this part of memory to be allocated in vain.

So two modifications have been made,
One is to add the 'volatile' modifier before 'closed',
One is to determine whether to 'closed' before allocating memory.

 

 

Issue Links

• links to: GitHub Pull Request #9817