Uploaded image for project: 'Kafka'
  1. Kafka
  2. KAFKA-10871

StreamTask shouldn't take WallClockTime as input parameter in process method

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Not A Bug
    • 2.7.0
    • None
    • streams

    Description

      While working on https://issues.apache.org/jira/browse/KAFKA-10062 I realized process method in StreamTask is taking
      wallClockTime as input parameter which is redundant as StreamTask already contains time(https://github.com/apache/kafka/blob/2.5.0/streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java#L75) field which represents wallClockTime.
      In process method (https://github.com/apache/kafka/blob/2.7/streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java#L664), wallClockTime can be passed from StreamTask's time field itself.
      This method was changed as part of pr: https://github.com/apache/kafka/pull/7997.
      As part of https://issues.apache.org/jira/browse/KAFKA-10062, I believe wallClockTime need not be stored in ProcessorContext(https://github.com/apache/kafka/blob/trunk/streams/src/main/java/org/apache/kafka/streams/processor/internals/AbstractProcessorContext.java#L48) but should be fetched from StreamTask's time field. Reference pr: https://github.com/apache/kafka/pull/9744

      Attachments

        Activity

          People

            rohitdeshaws Rohit Deshpande
            rohitdeshaws Rohit Deshpande
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: