Kafka
  1. Kafka
  2. KAFKA-1084

Validate properties for custom serializers

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.8.1
    • Component/s: None
    • Labels:
      None

      Description

      We use specifics encoder/decoder for our producers/consumers, they get correctly initialized by the Producer/Consumer. The only downside is the validate() function of VerifiableProperties that pollutes our log stream.

      This patch allows custom serializers keys to validate correctly if they begin with the "external" prefix, for example:

      external.my.encoder.param=true

      will not raise a WARN.

        Activity

        Francois Saint-Jacques created issue -
        Francois Saint-Jacques made changes -
        Field Original Value New Value
        Attachment validate-external-properties.patch [ 12608055 ]
        Hide
        Jun Rao added a comment -

        Thanks for the patch. Do you think the patch in KAFKA-1049 addresses the problem better?

        Show
        Jun Rao added a comment - Thanks for the patch. Do you think the patch in KAFKA-1049 addresses the problem better?
        Hide
        Francois Saint-Jacques added a comment -

        I believe a warning will still get logged for unknown string properties since the patch in KAFKA-1049 doesn't touch the validate function.

        Show
        Francois Saint-Jacques added a comment - I believe a warning will still get logged for unknown string properties since the patch in KAFKA-1049 doesn't touch the validate function.
        Jun Rao made changes -
        Assignee Francois Saint-Jacques [ fsaintjacques ]
        Hide
        Jun Rao added a comment -

        Yes, you are right. +1 on the patch. Committed to trunk.

        Show
        Jun Rao added a comment - Yes, you are right. +1 on the patch. Committed to trunk.
        Jun Rao made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 0.8.1 [ 12322960 ]
        Resolution Fixed [ 1 ]
        Jun Rao made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        3d 21h 47m 1 Jun Rao 15/Oct/13 17:48
        Resolved Resolved Closed Closed
        6s 1 Jun Rao 15/Oct/13 17:48

          People

          • Assignee:
            Francois Saint-Jacques
            Reporter:
            Francois Saint-Jacques
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development