Kafka
  1. Kafka
  2. KAFKA-108

A new unit test for ByteBufferMessageSet iterator

    Details

    • Type: Test Test
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.7
    • Component/s: None
    • Labels:
      None

      Description

      We need to add a unit test that iterates ByteBufferMessageSet with compression and without. Also, test that ByteBufferMessageSet can be iterated multiple times.

      1. kafka-108.patch
        2 kB
        Jun Rao
      2. kafka-108.patch.v2
        5 kB
        Jun Rao

        Activity

        Jun Rao created issue -
        Hide
        Jun Rao added a comment -

        Patch attached.

        Show
        Jun Rao added a comment - Patch attached.
        Jun Rao made changes -
        Field Original Value New Value
        Attachment kafka-108.patch [ 12490675 ]
        Jun Rao made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Jun Rao added a comment -

        Attaching patch v2. The unit test fails and exposes a bug on handling compressed empty ByteBufferMessageSet.

        Show
        Jun Rao added a comment - Attaching patch v2. The unit test fails and exposes a bug on handling compressed empty ByteBufferMessageSet.
        Jun Rao made changes -
        Attachment kafka-108.patch.v2 [ 12490709 ]
        Hide
        Neha Narkhede added a comment -

        +1. All tests look good.

        Show
        Neha Narkhede added a comment - +1. All tests look good.
        Jun Rao made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Fix Version/s 0.7 [ 12317243 ]
        Resolution Fixed [ 1 ]

          People

          • Assignee:
            Jun Rao
            Reporter:
            Jun Rao
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development