Kafka
  1. Kafka
  2. KAFKA-1046

Added support for Scala 2.10 builds while maintaining compatibility with 2.8.x

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.8.0
    • Fix Version/s: 0.8.0
    • Component/s: None
    • Labels:
      None

      Description

      I refactored the project such that it will compile against Scala 2.10.1.

      1. Screen Shot 2013-09-09 at 9.34.09 AM.png
        144 kB
        Neha Narkhede
      2. kafka_2_10_refactor_0.8.patch
        90 kB
        Christopher Freeman
      3. kafka_2_10_refactor.patch
        90 kB
        Christopher Freeman

        Issue Links

          Activity

          Hide
          Andrew Otto added a comment -

          Hm, I seem to be getting the same compilation error that is in the attached Screen Shot. How do I fix?

          Show
          Andrew Otto added a comment - Hm, I seem to be getting the same compilation error that is in the attached Screen Shot. How do I fix?
          Hide
          Neha Narkhede added a comment -

          Thanks for the patches. Checked in your patch to trunk

          Show
          Neha Narkhede added a comment - Thanks for the patches. Checked in your patch to trunk
          Hide
          Christopher Freeman added a comment -

          Review board for an updated trunk patch is here: https://reviews.apache.org/r/14111/

          Show
          Christopher Freeman added a comment - Review board for an updated trunk patch is here: https://reviews.apache.org/r/14111/
          Hide
          Neha Narkhede added a comment -

          Christopher Freeman We are ready to take the patch on trunk. Jun Rao has kindly taken the trouble to merge the 08 changes into trunk so there are fewer conflicts

          Show
          Neha Narkhede added a comment - Christopher Freeman We are ready to take the patch on trunk. Jun Rao has kindly taken the trouble to merge the 08 changes into trunk so there are fewer conflicts
          Hide
          Jun Rao added a comment -

          Chris,

          I merged everything in 0.8 before your change to trunk. Could you rebase your patch for trunk?

          Show
          Jun Rao added a comment - Chris, I merged everything in 0.8 before your change to trunk. Could you rebase your patch for trunk?
          Hide
          Neha Narkhede added a comment -

          Chris helped figure out how to get the Intellij build to work. Click on Intellij -> Preferences -> Compiler and uncheck "Use external build"

          +1 on the updated reviewboard patch.

          Chris, will keep this ticket open until you update the trunk patch.

          Show
          Neha Narkhede added a comment - Chris helped figure out how to get the Intellij build to work. Click on Intellij -> Preferences -> Compiler and uncheck "Use external build" +1 on the updated reviewboard patch. Chris, will keep this ticket open until you update the trunk patch.
          Hide
          Neha Narkhede added a comment -

          Intellij throws errors while compiling Annotations_2.9+.scala.

          Show
          Neha Narkhede added a comment - Intellij throws errors while compiling Annotations_2.9+.scala.
          Hide
          Neha Narkhede added a comment -

          Reviewboard is here - https://reviews.apache.org/r/14013/

          The patch looks good. I have some minor questions. It will be great if you take a look at those Chris.

          Show
          Neha Narkhede added a comment - Reviewboard is here - https://reviews.apache.org/r/14013/ The patch looks good. I have some minor questions. It will be great if you take a look at those Chris.
          Hide
          Joe Stein added a comment -

          +1 on kafka_2_10_refactor.patch

          patch looks good and tests pass for Scala 2.8.0, 2.9.1, 2.9.2, 2.10.1

          +1 on applying this to the trunk now and kafka_2_10_refactor_0.8.patch to the 0.8 branch too for next release

          Show
          Joe Stein added a comment - +1 on kafka_2_10_refactor.patch patch looks good and tests pass for Scala 2.8.0, 2.9.1, 2.9.2, 2.10.1 +1 on applying this to the trunk now and kafka_2_10_refactor_0.8.patch to the 0.8 branch too for next release
          Hide
          Joe Stein added a comment -

          +1 on kafka_2_10_refactor_0.8.patch

          patch looks good and tests pass for Scala 2.8.0, 2.9.1, 2.9.2, 2.10.1

          looking at the trunk patch now

          +1 on applying this to 0.8 branch now (and trunk too if that has same results) and have it as part of the 0.8.0-beta2 release

          Show
          Joe Stein added a comment - +1 on kafka_2_10_refactor_0.8.patch patch looks good and tests pass for Scala 2.8.0, 2.9.1, 2.9.2, 2.10.1 looking at the trunk patch now +1 on applying this to 0.8 branch now (and trunk too if that has same results) and have it as part of the 0.8.0-beta2 release
          Hide
          Christopher Freeman added a comment -

          added diff that applies cleanly to the 0.8 branch

          Show
          Christopher Freeman added a comment - added diff that applies cleanly to the 0.8 branch
          Hide
          Christopher Freeman added a comment -

          The patch is made against trunk. I will have to update it with one made against 0.8.

          Show
          Christopher Freeman added a comment - The patch is made against trunk. I will have to update it with one made against 0.8.
          Hide
          Neha Narkhede added a comment -

          Is this a patch against trunk? Do you also want to submit a patch against the 0.8 branch?

          Show
          Neha Narkhede added a comment - Is this a patch against trunk? Do you also want to submit a patch against the 0.8 branch?
          Hide
          Christopher Freeman added a comment -

          the diff

          Show
          Christopher Freeman added a comment - the diff

            People

            • Assignee:
              Christopher Freeman
              Reporter:
              Christopher Freeman
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development