Uploaded image for project: 'Kafka'
  1. Kafka
  2. KAFKA-10395

TopologyTestDriver does not work with dynamic topic routing

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.7.0, 2.6.1
    • Component/s: streams
    • Labels:

      Description

      The TopologyTestDriver#read(topic) methods all call #getRecordsQueue which checks 

       

      final Queue<ProducerRecord<byte[], byte[]>> outputRecords = outputRecordsByTopic.get(topicName);
      if (outputRecords == null) {
          if (!processorTopology.sinkTopics().contains(topicName)) {
              throw new IllegalArgumentException("Unknown topic: " + topicName); 
          } 
      }
      

      The outputRecordsByTopic map keeps track of all topics that are actually produced to, but obviously doesn't capture any topics that haven't yet received output. The `processorTopology#sinkTopics` is supposed to account for that by checking to make sure the topic is actually registered in the topology, and throw an exception if not in case the user supplied the wrong topic name to read from. 

      Unfortunately the TopicNameExtractor allows for dynamic routing of records to any topic, so the topology isn't aware of all the possible output topics. If trying to read from one of these topics that happens to not have received any output yet, the test will throw the above misleading IllegalArgumentException.

      We could just relax this check, but warning users who may actually have accidentally passed in the wrong topic to read from seems quite useful. A better solution would be to require registering all possible output topics to the TTD up front. This would obviously require a KIP, but it would be a very small one and shouldn't be too much trouble

       

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                ableegoldman A. Sophie Blee-Goldman
                Reporter:
                ableegoldman A. Sophie Blee-Goldman
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: