Uploaded image for project: 'Kafka'
  1. Kafka
  2. KAFKA-10070

Parameterize Connect unit tests to remove code duplication

    XMLWordPrintableJSON

    Details

    • Type: Task
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: 2.6.0
    • Fix Version/s: None
    • Component/s: KafkaConnect
    • Labels:
      None

      Description

      https://github.com/apache/kafka/pull/8722 added two new unit tests, WorkerWithTopicCreationTest and WorkerSourceTaskWithTopicCreationTest, that are almost complete clones of the existing WorkerTest and WorkerSourceTaskTest unit tests. There's a couple of comments (1, 2) in them about plans to parameterize the tests; we should do this sooner rather than later to avoid expending developer time on copy+pasting code changes across two tests when making modifications to the Worker and/or WorkerSourceTask classes.

        Attachments

          Activity

            People

            • Assignee:
              kkonstantine Konstantine Karantasis
              Reporter:
              ChrisEgerton Chris Egerton
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated: