Uploaded image for project: 'Maven JXR'
  1. Maven JXR
  2. JXR-59

speed up AbstractJxrReport.hasSources()

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1
    • Fix Version/s: 2.3
    • Component/s: maven2 jxr plugin
    • Labels:
      None

      Description

      The method AbstractJxrReport.hasSources( File dir ) spends a lot of time scanning .svn directories when I do my build.

      If you replace the line,

      else if ( currentFile.isDirectory() )

      with the lines

      else if ( currentFile.isDirectory()  &&
                   Character.isJavaIdentifierStart(currentFile.getName().charAt(0))
      )

      You will speed this up.

      If the first character in the directory is not a valid java identifier start, then the directory cannot contain java code. '.' is not a valid java identifier start, so .svn directories are ignored when scanning for sources.

        Attachments

          Activity

            People

            • Assignee:
              hboutemy Hervé Boutemy
              Reporter:
              sgbridges Sean Bridges
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: