[JXPATH-55] unnecessary reflection

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: Nightly Builds

Environment

Operating System: All
Platform: All

• Bugzilla Id: 13108
• Assignee: Unassigned
• Reporter: Kees Kuip
• Created: 28/Sep/02 15:39
• Updated: 16/May/06 12:47
• Resolved: 16/May/06 12:47

Description

Hello,

I think that in BeanPropertyPointer.java there is an unnecessary use of
reflection.

If you get a member of a collection then the collection will be
fetched twice through reflection.

The SimplePathInterpreter.java has the following code :

if (index >= 0 && index < pointer.getLength())

{ pointer.setIndex(index); return pointer.getValuePointer(); }

The pointer.getLength() will set the 'baseValue' in BeanPropertyPointer.
The pointer.getValuePointer() will wet the 'value' in BeanPropertyPointer.

Both will do reflection.

getValuePointer() calls getNode().
getNodeValue() doesn't use the 'baseValue' and I think it can !

So I changed getNode() into :

public Object getNode(){
if (value == UNINITIALIZED){
PropertyDescriptor pd = getPropertyDescriptor();
if (pd == null)

{ value = null; }

else {
getBaseValue();

if(baseValue != null) {
if (index == WHOLE_COLLECTION)

{ value = baseValue; }

else if (index >= 0 && index < getLength())

{ value = ValueUtils.getValue(baseValue, index); }

}
}
}
return value;
}

Kees.