Commons JXPath
  1. Commons JXPath
  2. JXPATH-149

relational operations do not function properly when comparing a non-Iterator LHS to an Iterator RHS

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.3
    • Fix Version/s: None
    • Labels:
      None

      Description

      I have a simple JXpathContext, with the following variables: var1=0, var2=0, var3=1. When I try to evaluate the following expression - "$var1 + $var2 <= $var3", it returns false.

      1. CoreOperationRelationalExpression.java
        5 kB
        Alexander Koledzhikov
      2. TestClass.java
        0.9 kB
        Alexander Koledzhikov

        Activity

        Hide
        Matt Benson added a comment -

        Disregard my previous request. I accidentally lost my local copy of your patch anyway and as it consisted solely of inversions of code already living in the file in question I simply rewrote from scratch.

        Committed revision 1133485.

        Show
        Matt Benson added a comment - Disregard my previous request. I accidentally lost my local copy of your patch anyway and as it consisted solely of inversions of code already living in the file in question I simply rewrote from scratch. Committed revision 1133485.
        Hide
        Matt Benson added a comment -

        Hi, I have reviewed your proposed fix and it looks good. For formality's sake, can you please declare that your changes are intended for inclusion into the Apache Commons JXPath library?

        Also, in the future, please provide your changes in the form of diff patches.

        Thanks!

        Show
        Matt Benson added a comment - Hi, I have reviewed your proposed fix and it looks good. For formality's sake, can you please declare that your changes are intended for inclusion into the Apache Commons JXPath library? Also, in the future, please provide your changes in the form of diff patches. Thanks!
        Hide
        Alexander Koledzhikov added a comment -

        Test case and proposed fix.

        Show
        Alexander Koledzhikov added a comment - Test case and proposed fix.

          People

          • Assignee:
            Unassigned
            Reporter:
            Alexander Koledzhikov
          • Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development