[JXPATH-107] RCN: Nullcheck of NodePointer.parent of value previously dereferenced in PropertyOwnerPointer.setValue(Object)

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: Nightly Builds
• Fix Version/s: 1.3

Environment

ALL

• Assignee: Unassigned
• Reporter: Michele Vivoda
• Created: 11/Dec/07 18:03
• Updated: 11/Dec/07 19:34
• Resolved: 11/Dec/07 19:33

Description

In class PropertyOwnerPointer, method setValue

The code says first

if (parent.isContainer()) ...

then it checks for parent not being null.

else if (parent != null) {

If the parent could be null the first code
would trigger a null pointer exception.

So I think:

now the parent happens to be never null
but either
1. the (parent!=null) check is unecessary
(I don't know the exact semantics of this class)
2. or more probably the

{parent.isContainer()}

block should be put inside
the

{parent!=null}

check.

An other findbugs find.