[JUDDI-434] make replace NullPointerException with "<operation> not found exception" in service wrappers

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.4
• Fix Version/s: 3.1.0
• Component/s: juddi-client
• Assignee: Thomas Cunningham
• Reporter: subes
• Created: 30/Nov/10 01:26
• Updated: 16/Dec/10 19:47
• Resolved: 16/Dec/10 19:47

Description

currently I am getting the following exception:

java.lang.NullPointerException
at org.apache.juddi.v3.client.transport.wrapper.UDDIPublicationService.publish(UDDIPublicationService.java:96)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:616)
at org.apache.ws.scout.transport.LocalTransport.send(LocalTransport.java:63)
at org.apache.ws.scout.registry.RegistryV3Impl.execute(RegistryV3Impl.java:296)
at org.apache.ws.scout.registry.RegistryV3Impl.getAssertionStatusReport(RegistryV3Impl.java:852)
at org.apache.ws.scout.registry.BusinessLifeCycleManagerV3Impl.clearPublisherAssertions(BusinessLifeCycleManagerV3Impl.java:626)
at org.apache.ws.scout.registry.BusinessLifeCycleManagerV3Impl.executeOperation(BusinessLifeCycleManagerV3Impl.java:588)
at org.apache.ws.scout.registry.BusinessLifeCycleManagerV3Impl.deleteOperation(BusinessLifeCycleManagerV3Impl.java:722)
at org.apache.ws.scout.registry.BusinessLifeCycleManagerV3Impl.deleteOrganizations(BusinessLifeCycleManagerV3Impl.java:154)
at de.invesdwin.gemeinsam.integration.ws.internal.jaxr.JaxrClientHelper.removeOrganization(JaxrClientHelper.java:105)
at de.invesdwin.gemeinsam.integration.ws.internal.jaxr.JaxrClient.unregisterServiceInstance(JaxrClient.java:88)
at de.invesdwin.gemeinsam.integration.ws.XsdWebServicePublikation.shutdown(XsdWebServicePublikation.java:80)
at de.invesdwin.gemeinsam.bootstrap.ShutdownHook$ShutdownHookThread.run(ShutdownHook.java:49)

Better would be some sort of message that tells me which operation was not found.
Fix could be:

...
String operation = requestHandler.getOperation(uddiReq);
Handler opHandler = operations.get(operation);
if(opHandler == null){
throw new IllegalArgumentException("operation not found: "+operation);
}
requestHandler.setMethodName(opHandler.getMethodName());
...

This item refers to https://issues.apache.org/jira/browse/SCOUT-108 and https://issues.apache.org/jira/browse/SCOUT-105