[JUDDI-376] Subscription results lost during renewal

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.1
• Fix Version/s: 3.0.2
• Environment: org.apache.juddi.api.impl.UDDISubscriptionImpl
• Assignee: Kurt Stam
• Reporter: Adam Pryce
• Created: 09/Mar/10 22:39
• Updated: 05/May/10 14:30
• Resolved: 05/May/10 14:24

Description

UDDISubscriptionImpl has a comment suggesting that if one wants the subscription to only notify on changes that happend since the last notify (as opposed to since the subscription was created) then one should renew.

UDDISubscriptonImpl: line 123:
"

• Notes: Does it make sense to refresh the subscription matches on a call to this method? I don't think so, the user theoretically had
• a set of entities in mind when the subscription was saved and the snapshot should remain just that - a snapshot of the entities at the
• time of the subscription save. The result of this policy is that if an entity is deleted, that deleted result will appear in the keyBag
• on every call to this method. To resolve this, the user can renew the subscription at which time the "match" snapshot will be refreshed.
  "
  However, when an asset is renewed its lastNotified field isn't preserved and subscription creation is set to the current time. This means that any changes during the time between when the subscription notified and it was then renewed is lost. It seems to me that the best methods to fix this would be to
  a) carry over the lastNotified and created fields during renewal
  or
  b) un-comment the lines referred to in the above comment (currently at 202, 253, 304, and 357).

I apologize that I am unable to test and commit these changes myself.