[JUDDI-375] Null Pointer Exception in SubscriptionNotifier

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.0.1
• Fix Version/s: 3.0.2
• Component/s: core
• Environment: org.apache.juddi.subscription.SubscriptionNotifier; When load becomes significant and the notifier falls behind.
• Assignee: Kurt Stam
• Reporter: Adam Pryce
• Created: 09/Mar/10 19:01
• Updated: 18/Mar/10 18:00
• Resolved: 18/Mar/10 18:00

Description

When the load becomes significant it is possible for the following if statement at line 144 to resolve to false resulting in a null pointer being returned

144: if (subscription.getLastNotified()==null || nextDesiredNotificationDate.after(startPoint) && nextDesiredNotificationDate.before(endPoint)) {

If this if statement is sensible then there needs to be a null pointer check around line 87 to avoid NullPointerException. I could see something like this:

86: GetSubscriptionResults getSubscriptionResults = buildGetSubscriptionResults(subscription, new Date(scheduledExecutionTime()));
if(getSubscriptionResults == null)
continue;
87: getSubscriptionResults.setSubscriptionKey(subscription.getSubscriptionKey());

I apologize that I cannot test and commit this change through subversion. I put priority to minor since the NPE seems to have relatively little impact in the long term, but in the short term all remaining subscriptions are skipped.