Uploaded image for project: 'JSPWiki'
  1. JSPWiki
  2. JSPWIKI-807

VersioningFileProvider pageExist failure to properly handle latest version

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.9.1
    • Fix Version/s: 2.10
    • Component/s: Core & storage
    • Labels:
    • Environment:

      All

      Description

      In VersioningFileProvider, the function "pageExists" for versions search for the versions of wiki page in the "OLD" directory for that page. The latest version is in the main storage directory. The problem is masked because the PageProvider class handles the case - which it should not. Adding the following code to pageExists and removing the code for PageProvider will resolve this issue:

      if( version == WikiPageProvider.LATEST_VERSION || version == latest)

      { return pageExists( pageName ); }

      else
      {

        Attachments

        1. case-2.patch-sortof
          5 kB
          KP Hemsteter
        2. case-1.patch-sortof
          0.7 kB
          KP Hemsteter
        3. JSPWIKI-807.patch
          1 kB
          Harry Metske

          Activity

            People

            • Assignee:
              metskem Harry Metske
              Reporter:
              greyman KP Hemsteter
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 1h
                1h
                Remaining:
                Remaining Estimate - 1h
                1h
                Logged:
                Time Spent - Not Specified
                Not Specified