[JSPWIKI-759] Resin 4 Compatibility

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.9
• Fix Version/s: 2.9.1
• Component/s: Servlet Container/Java compatibility

Environment

OSX 10.8.2, Oracle Java JDK 1.7.0_09, Resin Pro 4.0.34

• Assignee: Harry Metske
• Reporter: Paul Cowan
• Created: 31/Jan/13 19:40
• Updated: 15/Nov/21 13:49
• Resolved: 12/Feb/13 17:53

Description

I am an engineer for Caucho on the Resin Application Server, and was testing JSPWiki on Resin version 4.0.34. I would like to submit 2 fixes to enable JSPWiki to run better on Resin 4:

#1. JSPWiki is calling getOutputStream after getWriter(). The servlet spec dictates we throw IllegalStateException for this situation. I see JSPWiki already has handling in UtilJ2eeCompat to use an OutputStream rather than a Writer depending on the container. The Resin check should have "useStream = true".

#2. As a consequence of #1, JSPWiki serves empty content. This is due to buffering inside the PrintWriter used by WikiJSPFilter.ByteArrayResponseWrapper. The PrintWriter is never flushed when toString() is called on ByteArrayResponseWrapper. (This may not be a Resin specific issue.)

I will attempt to attach a patch file to this bug report containing my fix to WikiJSPFilter.java.

Issue Links

• is related to: JSPWIKI-874 java.lang.IllegalStateException
• is related to: JSPWIKI-126 call getWriter() after getOutputStream()
• is related to: JSPWIKI-396 UTF-8 characters in wiki pages incorrectly rendered if served by Weblogic