Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.9.1
    • Fix Version/s: 2.9.1
    • Component/s: Core & storage
    • Labels:
      None
    • Environment:

      JDK 7, Tomcat 7, Ubuntu Linux.

      Description

      Testing with Ant, I found four JARs declared for testing but not needed for it: custom_rhino-0.4.3.jar, jasper-compiler-5.5.23.jar, xercesImpl-2.6.2.jar, xml-apis-1.0.b2.jar. Further, Maven had detected that the stripes JAR, declared at the testing level, should be actually made available in the main JAR. Patch attached accomplishes these goals.

        Activity

        Hide
        gmazza Glen Mazza added a comment -

        Patch to remove unneeded JARs.

        Show
        gmazza Glen Mazza added a comment - Patch to remove unneeded JARs.
        Hide
        metskem Harry Metske added a comment -

        I was just wondering what we need Stripes for (in the current trunk).
        (I don't have very good internet access at the moment)

        Show
        metskem Harry Metske added a comment - I was just wondering what we need Stripes for (in the current trunk). (I don't have very good internet access at the moment)
        Hide
        metskem Harry Metske added a comment -

        Back to my own laptop, shows what Stripes is used for, the Exporter (rest is testcode):

        metskem@athena ~/workspace/JSPWiki-2.9 $ find . -name *.java -exec grep -l net.sourceforge.stripes {} \;
        ./src/org/apache/wiki/content/Exporter.java
        ./tests/org/apache/wiki/ui/CommandResolverTest.java
        ./tests/org/apache/wiki/TestEngine.java
        ./tests/org/apache/wiki/auth/login/WebContainerLoginModuleTest.java
        ./tests/org/apache/wiki/auth/login/CookieAssertionLoginModuleTest.java
        ./tests/org/apache/wiki/search/SearchManagerTest.java
        ./tests/org/apache/wiki/plugin/IfPluginTest.java
        ./tests/org/apache/wiki/WikiSessionTest.java
         

        So I think we still need Stripes for the test classes.
        I think we should remove Exporter from the code, we won't need it anymore since we will not be using JCR.
        WDYT?

        Show
        metskem Harry Metske added a comment - Back to my own laptop, shows what Stripes is used for, the Exporter (rest is testcode): metskem@athena ~/workspace/JSPWiki-2.9 $ find . -name *.java -exec grep -l net.sourceforge.stripes {} \; ./src/org/apache/wiki/content/Exporter.java ./tests/org/apache/wiki/ui/CommandResolverTest.java ./tests/org/apache/wiki/TestEngine.java ./tests/org/apache/wiki/auth/login/WebContainerLoginModuleTest.java ./tests/org/apache/wiki/auth/login/CookieAssertionLoginModuleTest.java ./tests/org/apache/wiki/search/SearchManagerTest.java ./tests/org/apache/wiki/plugin/IfPluginTest.java ./tests/org/apache/wiki/WikiSessionTest.java So I think we still need Stripes for the test classes. I think we should remove Exporter from the code, we won't need it anymore since we will not be using JCR. WDYT?
        Hide
        juanpablo Juan Pablo Santos Rodríguez added a comment -

        +1 on removing org.apache.wiki.content.Exporter

        As for the the jasper-* dependencies, they're are used only to precompile the JSPs (cfr. with war-tomcat target). They're with the test libraries just to ensure they don't end up with the main build. Haven't had time to check the rest of the jars..

        br,
        juan pablo

        Show
        juanpablo Juan Pablo Santos Rodríguez added a comment - +1 on removing org.apache.wiki.content.Exporter As for the the jasper-* dependencies, they're are used only to precompile the JSPs (cfr. with war-tomcat target). They're with the test libraries just to ensure they don't end up with the main build. Haven't had time to check the rest of the jars.. br, juan pablo
        Hide
        metskem Harry Metske added a comment -

        deleted Exporter and ExporterTest, kept build.xml intact for now.

        Show
        metskem Harry Metske added a comment - deleted Exporter and ExporterTest, kept build.xml intact for now.
        Hide
        metskem Harry Metske added a comment -

        Show
        metskem Harry Metske added a comment -
        Hide
        gmazza Glen Mazza added a comment -

        Custom-Rhino, Xalan, Xerces removed; retaining Jasper JAR per Juan's comment.

        Show
        gmazza Glen Mazza added a comment - Custom-Rhino, Xalan, Xerces removed; retaining Jasper JAR per Juan's comment.

          People

          • Assignee:
            gmazza Glen Mazza
            Reporter:
            gmazza Glen Mazza
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development