Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: Graduating, 2.9
    • Fix Version/s: 2.9
    • Component/s: None
    • Labels:
      None

      Description

      some libraries are present at Central, but with different versions:

      • jrcs-diff-0.2.jar -> The closest match I was able to find is JMeld, a LGPL app which includes the exact classes from jrcs-diff (among many others). There's also a newer version of the library at Central, at 3 but it includes a package rename. Other than, it seems fine, but this might be the most delicate jar to upgrade.
      • jasper-*-5.5.25.jar [2 files] -> downgrade to 5.5.23? We use them to precompile JSPs, downgrading shouldn't affect us and we could use the version from Central.
      • jetty-* [3 files] > upgrade to 7.0.0.pre5 (5.1.14 11MB zip downloadable at http://dist.codehaus.org/jetty/jetty-5.1.x/jetty-5.1.14.tgz). Have to locate the use of these jars to see the possible consequences of upgrading (there are earlier versions on Central of jetty*, except for the case of jetty-jmx, so it seems safer to upgrade all three of them to 7.0.0.pre5)
      • selenium-*-1.0-beta-1 [2 files] -> upgrade them to 1.0-beta-2. Not very sure if this could be done w/o changing code. If that's the case, we could try to upgrade to 1.0.2.

        Activity

        Hide
        Juan Pablo Santos Rodríguez added a comment -

        Regarding jetty-* files, there are a lot of changes switching from Jetty 5.x to 6.x and from 6.x to 7.x, so it probably makes sense to upgrade to Jetty 8.x and rewrite the container (which was going to be mostly-done anyways). The use of these jars is located in org.apache.wiki.web.TestContainer, launched through the webtest-exec macro.

        Any volunteers for taking this one?

        Tomcat and jrcs-diff related changes ought to be somewhat safe/fast to do.

        Finally, still have to take a look at Selenium, I'm not very sure of how much amount of code changes should it take...

        Show
        Juan Pablo Santos Rodríguez added a comment - Regarding jetty-* files, there are a lot of changes switching from Jetty 5.x to 6.x and from 6.x to 7.x, so it probably makes sense to upgrade to Jetty 8.x and rewrite the container (which was going to be mostly-done anyways). The use of these jars is located in org.apache.wiki.web.TestContainer, launched through the webtest-exec macro. Any volunteers for taking this one? Tomcat and jrcs-diff related changes ought to be somewhat safe/fast to do. Finally, still have to take a look at Selenium, I'm not very sure of how much amount of code changes should it take...
        Hide
        Harry Metske added a comment -

        Jetty 8 is JEE6 (Java 6 / Servlet 3.0)
        Jetty 7 is JEE5 (Java 5 / Servlet 2.5)
        See http://wiki.eclipse.org/Jetty/Starting/Jetty_Version_Comparison_Table

        So for now I opted for the stable Jetty 7 and rewrote the TestContainer, I have a working version available now.
        I started with the individual jetty component jars, and ended up needing 12 of those, so maybe it's better to use the jetty-all.jar from central.

        Now for the webtests, I don't have that working yet.
        TestContainer is only used by (selenium) webtests, is anyone ever using the webtests anyway ?
        I can remember a mail thread a few years ago that we gave up on webtests (can't find the trail however).

        I can spend some more time next week, see if I can get selenium work properly anyway.

        regards,
        Harry

        Show
        Harry Metske added a comment - Jetty 8 is JEE6 (Java 6 / Servlet 3.0) Jetty 7 is JEE5 (Java 5 / Servlet 2.5) See http://wiki.eclipse.org/Jetty/Starting/Jetty_Version_Comparison_Table So for now I opted for the stable Jetty 7 and rewrote the TestContainer, I have a working version available now. I started with the individual jetty component jars, and ended up needing 12 of those, so maybe it's better to use the jetty-all.jar from central. Now for the webtests, I don't have that working yet. TestContainer is only used by (selenium) webtests, is anyone ever using the webtests anyway ? I can remember a mail thread a few years ago that we gave up on webtests (can't find the trail however). I can spend some more time next week, see if I can get selenium work properly anyway. regards, Harry
        Hide
        Juan Pablo Santos Rodríguez added a comment -

        Oh, didn't see the Java 6 requirement for Jetty 8, so Jetty 7 should be fine. I also ended up with a bunch of Jetty jars, so seems to me that the aggregate jar should be a better option.

        Regarding selenium and webtests, I've been digging into it. 1 is the only thread I've regarding selenium and 2 seems to point that the Selenium server we're using supports only Firefox 1.4.1 to 2.0.0.*. Probably the same happens with IE or Safari.

        So I wouldn't bet that anyone is using them, at least nowadays. As the tests can be readed/executed with latest Selenium IDE, I was thinking in going into latest Selenium Server (perhaps translating the tests into JUnit).

        Also regarding the tests, they date back from a long time ago, so there's a chance that the front-end has evolved while the tests haven't, and there could be incompatibilities between them. If that's the case I would drop the tests, but not the Selenium support, we could add Selenium tests later on...

        rgrds,
        jp

        1: http://markmail.org/message/ywtaml3kftagqkdt
        2: http://www.qaautomation.net/?p=245

        Show
        Juan Pablo Santos Rodríguez added a comment - Oh, didn't see the Java 6 requirement for Jetty 8, so Jetty 7 should be fine. I also ended up with a bunch of Jetty jars, so seems to me that the aggregate jar should be a better option. Regarding selenium and webtests, I've been digging into it. 1 is the only thread I've regarding selenium and 2 seems to point that the Selenium server we're using supports only Firefox 1.4.1 to 2.0.0.*. Probably the same happens with IE or Safari. So I wouldn't bet that anyone is using them, at least nowadays. As the tests can be readed/executed with latest Selenium IDE, I was thinking in going into latest Selenium Server (perhaps translating the tests into JUnit). Also regarding the tests, they date back from a long time ago, so there's a chance that the front-end has evolved while the tests haven't, and there could be incompatibilities between them. If that's the case I would drop the tests, but not the Selenium support, we could add Selenium tests later on... rgrds, jp 1 : http://markmail.org/message/ywtaml3kftagqkdt 2 : http://www.qaautomation.net/?p=245
        Hide
        brushed added a comment -

        The selenium tests are still compatible with the current front-end.
        You can actually run -ant webtests, and see that most tests are running successfully.

        It should be possible to upgrade to the latest selenium 2.x which is backwards compatible.
        I was trying to upgrade

        • from tests/lib/selenium-server-1.0-beta1.jar
        • to tests/lib/selenium-server-standalone-2.25.0.jar
          This should not require any changes to the test-suite. (we are not using the java api)

        It noticed some changes to the command-line parameters for the Selenium 2 jar would be needed:

        • add the -port $ {webtests.port}

          argument.

        • (may be) add the -singleWindow argument.

        But so far I couldn't get it running, as for some reasons it doesn't seem to be able
        to find the TestSuite.html on the jetty server.

        dirk

        Show
        brushed added a comment - The selenium tests are still compatible with the current front-end. You can actually run -ant webtests, and see that most tests are running successfully. It should be possible to upgrade to the latest selenium 2.x which is backwards compatible. I was trying to upgrade from tests/lib/selenium-server-1.0-beta1.jar to tests/lib/selenium-server-standalone-2.25.0.jar This should not require any changes to the test-suite. (we are not using the java api) It noticed some changes to the command-line parameters for the Selenium 2 jar would be needed: add the -port $ {webtests.port} argument. (may be) add the -singleWindow argument. But so far I couldn't get it running, as for some reasons it doesn't seem to be able to find the TestSuite.html on the jetty server. dirk
        Hide
        Harry Metske added a comment -

        I did a quick test run yesterday with the selenium-server-standalone-2.25.0.jar, and that works fine with a current version of FireFox.
        Many tests did fail, but that could be an environmental error with me.
        I will commit the changes I made so far, and then try to get some webtests working.
        I will replace the 12 individual jetty jars with one jetty-all:
        http://mvnrepository.com/artifact/org.eclipse.jetty.aggregate/jetty-all/7.6.5.v20120716 .

        regards,
        Harry

        Show
        Harry Metske added a comment - I did a quick test run yesterday with the selenium-server-standalone-2.25.0.jar, and that works fine with a current version of FireFox. Many tests did fail, but that could be an environmental error with me. I will commit the changes I made so far, and then try to get some webtests working. I will replace the 12 individual jetty jars with one jetty-all: http://mvnrepository.com/artifact/org.eclipse.jetty.aggregate/jetty-all/7.6.5.v20120716 . regards, Harry
        Hide
        Harry Metske added a comment -

        Just committed the stuff, I hope I haven ruined too much.

        Show
        Harry Metske added a comment - Just committed the stuff, I hope I haven ruined too much.
        Hide
        Juan Pablo Santos Rodríguez added a comment -

        Completed in current trunk.

        @Dirk: thanks for the insights on upgrading Selenium

        @Harry: changed download URLs for Jetty and Selenium to avoid downloading anything from svn.apache.org during build time. While at it, also upgraded Jetty to latest 7.6.x. Other than that, TestContainer looks real nice!

        Show
        Juan Pablo Santos Rodríguez added a comment - Completed in current trunk. @Dirk: thanks for the insights on upgrading Selenium @Harry: changed download URLs for Jetty and Selenium to avoid downloading anything from svn.apache.org during build time. While at it, also upgraded Jetty to latest 7.6.x. Other than that, TestContainer looks real nice!
        Hide
        Florian Holeczek added a comment -

        Closing this, since 2.9 has been released

        Show
        Florian Holeczek added a comment - Closing this, since 2.9 has been released

          People

          • Assignee:
            Unassigned
            Reporter:
            Juan Pablo Santos Rodríguez
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development