Details

      Description

      If possible, log a clear hint to a running security manager being a problem for JSPWiki, in order to avoid long and difficult problem analysis in users' environments.
      This should of course only be a transitional hack.

      1. JSPWIKI-705.patch
        0.8 kB
        Florian Holeczek

        Activity

        Florian Holeczek created issue -
        Hide
        Florian Holeczek added a comment -

        changed summary

        Show
        Florian Holeczek added a comment - changed summary
        Florian Holeczek made changes -
        Field Original Value New Value
        Summary If possible, log a clear hint for the meantime Log a clear hint to a running security manager
        Hide
        Florian Holeczek added a comment -

        Also add a hint to the README.
        Does this affect 3.0, too?

        Show
        Florian Holeczek added a comment - Also add a hint to the README. Does this affect 3.0, too?
        Hide
        Florian Holeczek added a comment -

        Also see JSPWIKI-698. Should be done in 2.8.5.

        Show
        Florian Holeczek added a comment - Also see JSPWIKI-698 . Should be done in 2.8.5.
        Florian Holeczek made changes -
        Fix Version/s 2.8.5 [ 12315288 ]
        Hide
        Florian Holeczek added a comment -

        maybe also warn in Install.jsp

        Show
        Florian Holeczek added a comment - maybe also warn in Install.jsp
        Hide
        Harry Metske added a comment -

        I built the check in SessionMonitor, this is the first piece of JSPWiki code that get's control (and immediately fails because it tries to init a logger, which fails if java security is active).
        See the committed changes, let me know if you want something else.

        (Doing something in Install.jsp makes no sense since the whole webapp (JSPWiki) does not get started.)

        Show
        Harry Metske added a comment - I built the check in SessionMonitor, this is the first piece of JSPWiki code that get's control (and immediately fails because it tries to init a logger, which fails if java security is active). See the committed changes, let me know if you want something else. (Doing something in Install.jsp makes no sense since the whole webapp (JSPWiki) does not get started.)
        Hide
        Florian Holeczek added a comment -

        Hi Harry,

        unfortunately you're right with the Install.jsp - but would have been extremely user friendly

        Regarding your commit, I had chosen a different approach (see the attached patch).
        The main difference is that it doesn't prevent the wiki from being started. This way, a workaround (full permissions for this webapp) may be applied without needing to recompile.

        WDYT?

        Show
        Florian Holeczek added a comment - Hi Harry, unfortunately you're right with the Install.jsp - but would have been extremely user friendly Regarding your commit, I had chosen a different approach (see the attached patch). The main difference is that it doesn't prevent the wiki from being started. This way, a workaround (full permissions for this webapp) may be applied without needing to recompile. WDYT?
        Florian Holeczek made changes -
        Attachment JSPWIKI-705.patch [ 12494983 ]
        Hide
        Harry Metske added a comment -

        I'll have a look tonight, thanks.

        Show
        Harry Metske added a comment - I'll have a look tonight, thanks.
        Hide
        Harry Metske added a comment -

        Fixed in 2.8.5-svn-9 and 3.0.0-svn-232.

        Show
        Harry Metske added a comment - Fixed in 2.8.5-svn-9 and 3.0.0-svn-232.
        Harry Metske made changes -
        Status Open [ 1 ] Closed [ 6 ]
        Fix Version/s 3.0 [ 12312865 ]
        Resolution Fixed [ 1 ]
        Hide
        Florian Holeczek added a comment -

        Updates the ReleaseNotes, too.

        Show
        Florian Holeczek added a comment - Updates the ReleaseNotes, too.
        Hide
        Florian Holeczek added a comment -

        Reopen in order to add fix version 2.9

        Show
        Florian Holeczek added a comment - Reopen in order to add fix version 2.9
        Florian Holeczek made changes -
        Resolution Fixed [ 1 ]
        Status Closed [ 6 ] Reopened [ 4 ]
        Florian Holeczek made changes -
        Fix Version/s 2.9 [ 12319521 ]
        Florian Holeczek made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Assignee Florian Holeczek [ florianh ]
        Resolution Fixed [ 1 ]
        Hide
        Florian Holeczek added a comment -

        Closing this, since 2.9 has been released

        Show
        Florian Holeczek added a comment - Closing this, since 2.9 has been released
        Florian Holeczek made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Closed Closed
        5d 20h 10m 1 Harry Metske 20/Sep/11 16:31
        Closed Closed Reopened Reopened
        131d 53m 1 Florian Holeczek 29/Jan/12 17:24
        Reopened Reopened Resolved Resolved
        1m 9s 1 Florian Holeczek 29/Jan/12 17:25
        Resolved Resolved Closed Closed
        307d 17h 17m 1 Florian Holeczek 02/Dec/12 10:43

          People

          • Assignee:
            Unassigned
            Reporter:
            Florian Holeczek
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development