JSPWiki
  1. JSPWiki
  2. JSPWIKI-697

%collapse% does not collapse in Google Chrome browser 13.0.782

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Won't Fix
    • Affects Version/s: 2.8.2
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Environment:

      Win XP SP3. Chrome 13.0.782 browser.

      Description

      When clicking on a "+" to open a collapse section in Chrome, it does not open. This works on Windows and Firefox. I can hear you now: "upgrade to 2.8.4"!

        Activity

        Hide
        brushed added a comment -

        Something is going wrong in the function clickBullet() (only) in Chrome.
        Normally clickBullet should receive 3 parameters.
        But in chrome it receives an array with those 3 parameters.

        You can try following fix:

        Original code
        > clickBullet: function( ck, bulletidx, bodyfx){
        > var collapse = this.hasClass('collapseOpen'),
        > bodyHeight = bodyfx.element.scrollHeight;
        >
        > if(collapse) bodyfx.start(bodyHeight, 0); else bodyfx.start(bodyHeight);
        >
        > ck.value = ck.value.substring(0,bulletidx) + (collapse ? 'c' : 'o')
        > + ck.value.substring(bulletidx+1) ;
        > if(ck.name) Cookie.set(ck.name, ck.value,

        {path:Wiki.BasePath, duration:20}

        );
        > },

        Corrected code
        > clickBullet: function( ck, bulletidx, bodyfx){
        >
        > //protective GOOGLE CHROME fix
        > if($type(ck) == 'array')

        { > bulletidx = ck[1]; > bodyfx = ck[2]; > ck = ck[0]; > }

        >
        > var collapse = this.hasClass('collapseOpen'),
        > bodyHeight = bodyfx.element.scrollHeight;
        >
        > if(collapse) bodyfx.start(bodyHeight, 0); else bodyfx.start(bodyHeight);
        >
        > ck.value = ck.value.substring(0,bulletidx) + (collapse ? 'c' : 'o')
        > + ck.value.substring(bulletidx+1) ;
        > if(ck.name) Cookie.set(ck.name, ck.value,

        {path:Wiki.BasePath, duration:20}

        );
        > },

        If you are changing the compressed JS code, you probably need something like this:

        //protective GOOGLE CHROME fix
        if($type(ck) == 'array')

        { _ec = ck[1]; _ed = ck[2]; ck = ck[0]; }

        I need to check in which version of JSPWiki this is already resolved. So for the time, leave this issue open.

        dirk

        Show
        brushed added a comment - Something is going wrong in the function clickBullet() (only) in Chrome. Normally clickBullet should receive 3 parameters. But in chrome it receives an array with those 3 parameters. You can try following fix: Original code > clickBullet: function( ck, bulletidx, bodyfx){ > var collapse = this.hasClass('collapseOpen'), > bodyHeight = bodyfx.element.scrollHeight; > > if(collapse) bodyfx.start(bodyHeight, 0); else bodyfx.start(bodyHeight); > > ck.value = ck.value.substring(0,bulletidx) + (collapse ? 'c' : 'o') > + ck.value.substring(bulletidx+1) ; > if(ck.name) Cookie.set(ck.name, ck.value, {path:Wiki.BasePath, duration:20} ); > }, Corrected code > clickBullet: function( ck, bulletidx, bodyfx){ > > //protective GOOGLE CHROME fix > if($type(ck) == 'array') { > bulletidx = ck[1]; > bodyfx = ck[2]; > ck = ck[0]; > } > > var collapse = this.hasClass('collapseOpen'), > bodyHeight = bodyfx.element.scrollHeight; > > if(collapse) bodyfx.start(bodyHeight, 0); else bodyfx.start(bodyHeight); > > ck.value = ck.value.substring(0,bulletidx) + (collapse ? 'c' : 'o') > + ck.value.substring(bulletidx+1) ; > if(ck.name) Cookie.set(ck.name, ck.value, {path:Wiki.BasePath, duration:20} ); > }, If you are changing the compressed JS code, you probably need something like this: //protective GOOGLE CHROME fix if($type(ck) == 'array') { _ec = ck[1]; _ed = ck[2]; ck = ck[0]; } I need to check in which version of JSPWiki this is already resolved. So for the time, leave this issue open. dirk
        Hide
        brushed added a comment -

        Is resolved in Chrome v14.x.
        Don't fix.
        dirk

        Show
        brushed added a comment - Is resolved in Chrome v14.x. Don't fix. dirk
        Hide
        brushed added a comment -

        Browser issue, resolved in latest versions of Chrome.
        dirk

        Show
        brushed added a comment - Browser issue, resolved in latest versions of Chrome. dirk

          People

          • Assignee:
            brushed
            Reporter:
            Karl Hansen
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development