JSPWiki
  1. JSPWiki
  2. JSPWIKI-683

sortable tables do not work in Google Chrome (Uncaught TypeError: Cannot read property 'filterStack' of null)

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.8.4, 2.8.5, 2.9
    • Fix Version/s: 2.9
    • Component/s: Editors
    • Labels:
      None
    • Environment:

      JSPWiki 2.8.5
      Google Chrome 8.0.552.237 (and also Chromium 8.0.552.237 (70801) Ubuntu 10.10 )

      Description

      Create a wiki page with the following content :

      %%sortable
      ||header1 ||header2
      |cell1a | cell2a
      |cell2a | cell2b
      %%
      

      Click on the table headers to sort, the following error pops up in the java console :

      Uncaught TypeError: Cannot read property 'filterStack' of null
      

      I also tested with other browsers at my proposal, (Opera 11.01 and Firefox 3.6.13) and there the problem does not occur.

      I don't know if this is a javascript bug or a browser bug.

        Activity

        Hide
        Harry Metske added a comment -

        And BTW, it's not only a javascript error message, also the table sorting does not work in Chrome.

        Show
        Harry Metske added a comment - And BTW, it's not only a javascript error message, also the table sorting does not work in Chrome.
        Hide
        Harry Metske added a comment -

        As requested on the list, thanks Dirk.

        Show
        Harry Metske added a comment - As requested on the list, thanks Dirk.
        Hide
        brushed added a comment -

        There's a bug in the javascript event handler binding.

        Replace:
        th.addEvent('click', this.sort.bind(this,[th]) )

        by:
        th.addEvent('click', this.sort.bind(this,th) )

        Strangely enough, it only affects Chrome.

        I will include the bugfix in my next commit.
        dirk

        Show
        brushed added a comment - There's a bug in the javascript event handler binding. Replace: th.addEvent('click', this.sort.bind(this, [th] ) ) by: th.addEvent('click', this.sort.bind(this,th) ) Strangely enough, it only affects Chrome. I will include the bugfix in my next commit. dirk
        Hide
        brushed added a comment -

        Fixed in 2.9.0-incubating-1

        Show
        brushed added a comment - Fixed in 2.9.0-incubating-1
        Hide
        Florian Holeczek added a comment -

        Thanks Dirk for fixing this one!

        Since we're already voting on 2.9.0-incubating-0, this fix isn't included yet. I propose to include this one in our first "incubated" release afterwards. Opinions?

        Regards
        Florian

        Show
        Florian Holeczek added a comment - Thanks Dirk for fixing this one! Since we're already voting on 2.9.0-incubating-0, this fix isn't included yet. I propose to include this one in our first "incubated" release afterwards. Opinions? Regards Florian
        Hide
        Juan Pablo Santos Rodríguez added a comment -

        I would put it on 2.9 only if the vote for releasing 2.9 fails at general@incubator, so we are able to push a new tag/artifacts to vote upon.

        However, if the vote passes, I would push this one into 2.9.1 (created the version in JIRA a few moments ago), no matter whenever it is released, before or after graduation.

        rgrds,
        juan pablo

        Show
        Juan Pablo Santos Rodríguez added a comment - I would put it on 2.9 only if the vote for releasing 2.9 fails at general@incubator, so we are able to push a new tag/artifacts to vote upon. However, if the vote passes, I would push this one into 2.9.1 (created the version in JIRA a few moments ago), no matter whenever it is released, before or after graduation. rgrds, juan pablo
        Hide
        brushed added a comment -

        This issue also affects FF (tested on v13.1) ; and is also applicable to v2.8.4.

        Show
        brushed added a comment - This issue also affects FF (tested on v13.1) ; and is also applicable to v2.8.4.
        Hide
        Florian Holeczek added a comment -

        Closing this, since 2.9 has been released

        Show
        Florian Holeczek added a comment - Closing this, since 2.9 has been released

          People

          • Assignee:
            brushed
            Reporter:
            Harry Metske
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development